Re: Review Request 62148: Made the `stop()` logic in the scheduler library simpler.

2017-09-07 Thread Anand Mazumdar
> On Sept. 7, 2017, 3:33 p.m., Benjamin Hindman wrote: > > include/mesos/v1/scheduler.hpp > > Lines 25 (patched) > > > > > > Have we pulled in libprocess dependencies in public headers in the past? hmm, most of our m

Re: Review Request 62148: Made the `stop()` logic in the scheduler library simpler.

2017-09-07 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62148/#review184823 --- include/mesos/v1/scheduler.hpp Lines 25 (patched)

Re: Review Request 62148: Made the `stop()` logic in the scheduler library simpler.

2017-09-07 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62148/#review184820 --- FAIL: Some Mesos tests failed. Please check http://dcos-win.westu

Re: Review Request 62148: Made the `stop()` logic in the scheduler library simpler.

2017-09-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62148/ --- (Updated Sept. 7, 2017, 5:54 a.m.) Review request for mesos, Benjamin Hindman,

Review Request 62148: Made the `stop()` logic in the scheduler library simpler.

2017-09-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62148/ --- Review request for mesos, Benjamin Hindman, Benjamin Mahler, and Vinod Kone. Re