Re: Review Request 62187: Fixed broken pipe error in IOSwitchboard.

2018-09-18 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62187/#review208709
---



PASS: Mesos patch 62187 was successfully built and tested.

Reviews applied: `['68232', '68230', '68231', '65168', '62187']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2349/mesos-review-62187

- Mesos Reviewbot Windows


On Sept. 10, 2018, 6 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62187/
> ---
> 
> (Updated Sept. 10, 2018, 6 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8545
> https://issues.apache.org/jira/browse/MESOS-8545
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We force IOSwitchboard to return a final response to the client for the
> `ATTACH_CONTAINER_INPUT` call after IO redirects are finished. In this
> case, we don't read remaining messages from the input stream. So the
> agent might send an acknowledgment for the request before IOSwitchboard
> has received remaining messages. We need to delay termination of
> IOSwitchboard to give it a chance to read the remaining messages.
> Otherwise, the agent might get `HTTP 500` "broken pipe" while
> attempting to write the final message.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 
> 52b0e521ed1c651c90b3a3df7c4df576288bf400 
> 
> 
> Diff: https://reviews.apache.org/r/62187/diff/6/
> 
> 
> Testing
> ---
> 
> internal CI (3x times)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>



Re: Review Request 62187: Fixed broken pipe error in IOSwitchboard.

2018-09-18 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62187/#review208704
---


Ship it!




Ship It!

- Alexander Rukletsov


On Sept. 10, 2018, 6 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62187/
> ---
> 
> (Updated Sept. 10, 2018, 6 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8545
> https://issues.apache.org/jira/browse/MESOS-8545
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We force IOSwitchboard to return a final response to the client for the
> `ATTACH_CONTAINER_INPUT` call after IO redirects are finished. In this
> case, we don't read remaining messages from the input stream. So the
> agent might send an acknowledgment for the request before IOSwitchboard
> has received remaining messages. We need to delay termination of
> IOSwitchboard to give it a chance to read the remaining messages.
> Otherwise, the agent might get `HTTP 500` "broken pipe" while
> attempting to write the final message.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 
> 52b0e521ed1c651c90b3a3df7c4df576288bf400 
> 
> 
> Diff: https://reviews.apache.org/r/62187/diff/5/
> 
> 
> Testing
> ---
> 
> internal CI (3x times)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>



Re: Review Request 62187: Fixed broken pipe error in IOSwitchboard.

2018-09-13 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62187/#review208597
---



PASS: Mesos patch 62187 was successfully built and tested.

Reviews applied: `['68232', '68230', '68231', '65168', '62187']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2329/mesos-review-62187

- Mesos Reviewbot Windows


On Sept. 10, 2018, 6 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62187/
> ---
> 
> (Updated Sept. 10, 2018, 6 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8545
> https://issues.apache.org/jira/browse/MESOS-8545
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We force IOSwitchboard to return a final response to the client for the
> `ATTACH_CONTAINER_INPUT` call after IO redirects are finished. In this
> case, we don't read remaining messages from the input stream. So the
> agent might send an acknowledgment for the request before IOSwitchboard
> has received remaining messages. We need to delay termination of
> IOSwitchboard to give it a chance to read the remaining messages.
> Otherwise, the agent might get `HTTP 500` "broken pipe" while
> attempting to write the final message.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 
> 52b0e521ed1c651c90b3a3df7c4df576288bf400 
> 
> 
> Diff: https://reviews.apache.org/r/62187/diff/5/
> 
> 
> Testing
> ---
> 
> internal CI (3x times)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>



Re: Review Request 62187: Fixed broken pipe error in IOSwitchboard.

2018-09-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62187/#review208569
---



PASS: Mesos patch 62187 was successfully built and tested.

Reviews applied: `['68232', '68230', '68231', '65168', '62187']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2325/mesos-review-62187

- Mesos Reviewbot Windows


On Sept. 10, 2018, 6 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62187/
> ---
> 
> (Updated Sept. 10, 2018, 6 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8545
> https://issues.apache.org/jira/browse/MESOS-8545
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We force IOSwitchboard to return a final response to the client for the
> `ATTACH_CONTAINER_INPUT` call after IO redirects are finished. In this
> case, we don't read remaining messages from the input stream. So the
> agent might send an acknowledgment for the request before IOSwitchboard
> has received remaining messages. We need to delay termination of
> IOSwitchboard to give it a chance to read the remaining messages.
> Otherwise, the agent might get `HTTP 500` "broken pipe" while
> attempting to write the final message.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 
> 52b0e521ed1c651c90b3a3df7c4df576288bf400 
> 
> 
> Diff: https://reviews.apache.org/r/62187/diff/4/
> 
> 
> Testing
> ---
> 
> internal CI (3x times)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>



Re: Review Request 62187: Fixed broken pipe error in IOSwitchboard.

2018-09-11 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62187/#review208516
---



PASS: Mesos patch 62187 was successfully built and tested.

Reviews applied: `['68232', '68230', '68231', '65168', '62187']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2319/mesos-review-62187

- Mesos Reviewbot Windows


On Sept. 10, 2018, 8 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62187/
> ---
> 
> (Updated Sept. 10, 2018, 8 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8545
> https://issues.apache.org/jira/browse/MESOS-8545
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We force IOSwitchboard to return a final response to the client for the
> `ATTACH_CONTAINER_INPUT` call after IO redirects are finished. In this
> case, we don't read remaining messages from the input stream. So the
> agent might send an acknowledgment for the request before IOSwitchboard
> has received remaining messages. We need to delay termination of
> IOSwitchboard to give it a chance to read the remaining messages.
> Otherwise, the agent might get `HTTP 500` "broken pipe" while
> attempting to write the final message.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 
> 52b0e521ed1c651c90b3a3df7c4df576288bf400 
> 
> 
> Diff: https://reviews.apache.org/r/62187/diff/3/
> 
> 
> Testing
> ---
> 
> internal CI (3x times)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>



Re: Review Request 62187: Fixed broken pipe error in IOSwitchboard.

2018-09-10 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62187/#review208498
---



PASS: Mesos patch 62187 was successfully built and tested.

Reviews applied: `['68232', '68230', '68231', '65168', '62187']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2314/mesos-review-62187

- Mesos Reviewbot Windows


On Sept. 10, 2018, 8 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62187/
> ---
> 
> (Updated Sept. 10, 2018, 8 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8545
> https://issues.apache.org/jira/browse/MESOS-8545
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We force the `ATTACH_CONTAINER_INPUT` request to return a final
> response to the client after IO redirects are finished. In this case,
> we don't read remaining messages from the `ATTACH_CONTAINER_INPUT`
> request. So the agent might send an acknowledgment for the request
> before IOSwitchboard has received remaining messages. We need to delay
> termination of IOSwitchboard to give it a chance to read the remaining
> messages. Otherwise, the agent might get `HTTP 500` "broken pipe" while
> attempting to write the final message.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 
> 52b0e521ed1c651c90b3a3df7c4df576288bf400 
> 
> 
> Diff: https://reviews.apache.org/r/62187/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI (3x times)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>



Re: Review Request 62187: Fixed broken pipe error in IOSwitchboard.

2018-09-10 Thread Andrei Budnik

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62187/
---

(Updated Sept. 10, 2018, 6 p.m.)


Review request for mesos, Andrei Budnik and Alexander Rukletsov.


Summary (updated)
-

Fixed broken pipe error in IOSwitchboard.


Repository: mesos


Description (updated)
---

We force the `ATTACH_CONTAINER_INPUT` request to return a final
response to the client after IO redirects are finished. In this case,
we don't read remaining messages from the `ATTACH_CONTAINER_INPUT`
request. So the agent might send an acknowledgment for the request
before IOSwitchboard has received remaining messages. We need to delay
termination of IOSwitchboard to give it a chance to read the remaining
messages. Otherwise, the agent might get `HTTP 500` "broken pipe" while
attempting to write the final message.


Diffs (updated)
-

  src/slave/containerizer/mesos/io/switchboard.cpp 
52b0e521ed1c651c90b3a3df7c4df576288bf400 


Diff: https://reviews.apache.org/r/62187/diff/2/

Changes: https://reviews.apache.org/r/62187/diff/1-2/


Testing
---

internal CI (3x times)


Thanks,

Andrei Budnik