Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

2017-10-18 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62781/#review188467 --- src/webui/master/static/js/controllers.js Line 50 (original), 86

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

2017-10-06 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62781/#review187304 --- FAIL: The system cannot find the file specified. Reviews

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

2017-10-06 Thread Gaston Kleiman
> On Oct. 6, 2017, 12:55 p.m., Benjamin Mahler wrote: > > src/webui/master/static/js/controllers.js > > Lines 30-31 (original), 43-44 (patched) > > > > > > Stale? Good catch! =) - Gaston

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

2017-10-06 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62781/ --- (Updated Oct. 6, 2017, 2:05 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

2017-10-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62781/#review187294 --- Fix it, then Ship it! Thanks for taking this on! Just a few

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

2017-10-06 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62781/#review187293 --- FAIL: The system cannot find the file specified. Reviews

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

2017-10-06 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62781/ --- (Updated Oct. 6, 2017, 11:42 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

2017-10-06 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62781/ --- (Updated Oct. 6, 2017, 11:37 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

2017-10-04 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62781/#review187160 --- Patch looks great! Reviews applied: [62780, 62781] Passed

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

2017-10-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62781/#review187157 --- FAIL: Failed to apply the dependent review: 62780. Failed

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

2017-10-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62781/#review187156 --- FAIL: Failed to apply the dependent review: 62780. Failed

Review Request 62781: Mesos UI: extract the agent URL generation to a function.

2017-10-04 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62781/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description