Re: Review Request 62965: Added doc for cgroups devices isolator.

2018-01-12 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62965/#review195355
---


Ship it!




Ship It!

- Gilbert Song


On Jan. 12, 2018, 8:24 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62965/
> ---
> 
> (Updated Jan. 12, 2018, 8:24 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added doc for cgroups devices isolator.
> 
> 
> Diffs
> -
> 
>   docs/isolators/cgroups-devices.md PRE-CREATION 
>   docs/mesos-containerizer.md 28d5ccd1fb760485a92ec532c301958224e39526 
> 
> 
> Diff: https://reviews.apache.org/r/62965/diff/4/
> 
> 
> Testing
> ---
> 
> https://github.com/jieyu/mesos/blob/doc/docs/isolators/cgroups-devices.md
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62965: Added doc for cgroups devices isolator.

2018-01-12 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62965/#review195335
---



PASS: Mesos patch 62965 was successfully built and tested.

Reviews applied: `['62965']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62965

- Mesos Reviewbot Windows


On Jan. 12, 2018, 4:24 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62965/
> ---
> 
> (Updated Jan. 12, 2018, 4:24 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added doc for cgroups devices isolator.
> 
> 
> Diffs
> -
> 
>   docs/isolators/cgroups-devices.md PRE-CREATION 
>   docs/mesos-containerizer.md 28d5ccd1fb760485a92ec532c301958224e39526 
> 
> 
> Diff: https://reviews.apache.org/r/62965/diff/4/
> 
> 
> Testing
> ---
> 
> https://github.com/jieyu/mesos/blob/doc/docs/isolators/cgroups-devices.md
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62965: Added doc for cgroups devices isolator.

2018-01-12 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62965/
---

(Updated Jan. 12, 2018, 4:24 p.m.)


Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.


Repository: mesos


Description
---

Added doc for cgroups devices isolator.


Diffs (updated)
-

  docs/isolators/cgroups-devices.md PRE-CREATION 
  docs/mesos-containerizer.md 28d5ccd1fb760485a92ec532c301958224e39526 


Diff: https://reviews.apache.org/r/62965/diff/4/

Changes: https://reviews.apache.org/r/62965/diff/3-4/


Testing
---

https://github.com/jieyu/mesos/blob/doc/docs/isolators/cgroups-devices.md


Thanks,

Jie Yu

Re: Review Request 62965: Added doc for cgroups devices isolator.

2018-01-11 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62965/#review195292
---



PASS: Mesos patch 62965 was successfully built and tested.

Reviews applied: `['62965']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62965

- Mesos Reviewbot Windows


On Jan. 12, 2018, 2:20 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62965/
> ---
> 
> (Updated Jan. 12, 2018, 2:20 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added doc for cgroups devices isolator.
> 
> 
> Diffs
> -
> 
>   docs/isolators/cgroups-devices.md PRE-CREATION 
>   docs/mesos-containerizer.md 28d5ccd1fb760485a92ec532c301958224e39526 
> 
> 
> Diff: https://reviews.apache.org/r/62965/diff/3/
> 
> 
> Testing
> ---
> 
> https://github.com/jieyu/mesos/blob/doc/docs/isolators/cgroups-devices.md
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62965: Added doc for cgroups devices isolator.

2018-01-11 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62965/
---

(Updated Jan. 12, 2018, 2:20 a.m.)


Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.


Changes
---

Addressed comments.


Repository: mesos


Description
---

Added doc for cgroups devices isolator.


Diffs (updated)
-

  docs/isolators/cgroups-devices.md PRE-CREATION 
  docs/mesos-containerizer.md 28d5ccd1fb760485a92ec532c301958224e39526 


Diff: https://reviews.apache.org/r/62965/diff/3/

Changes: https://reviews.apache.org/r/62965/diff/2-3/


Testing
---

https://github.com/jieyu/mesos/blob/doc/docs/isolators/cgroups-devices.md


Thanks,

Jie Yu

Re: Review Request 62965: Added doc for cgroups devices isolator.

2017-10-13 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62965/#review187980
---



Is there any interaction with capabilities or filesystem isolation that should 
be mentioned? i.e. if a task does `mknod` is that always global or does it 
depend on whether there is a private mount of `/dev`? Are there interactions 
with udev that matter here? Is there any interaction with GPU devices that we 
should make explicit?


docs/isolators/cgroups-devices.md
Lines 8 (patched)


s/devices/device/



docs/isolators/cgroups-devices.md
Lines 27 (patched)


Can you elaborate on what is meant by "make new devices"?

Maybe:

```
Make new character devices using the 
[mknod(2)](http://man7.org/linux/man-pages/man2/mknod.2.html) system call.
```


- James Peach


On Oct. 13, 2017, 1:30 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62965/
> ---
> 
> (Updated Oct. 13, 2017, 1:30 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added doc for cgroups devices isolator.
> 
> 
> Diffs
> -
> 
>   docs/isolators/cgroups-devices.md PRE-CREATION 
>   docs/mesos-containerizer.md 4c82474cd748abf6490fec51c8146fa8b8345906 
> 
> 
> Diff: https://reviews.apache.org/r/62965/diff/2/
> 
> 
> Testing
> ---
> 
> https://github.com/jieyu/mesos/blob/doc/docs/isolators/cgroups-devices.md
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62965: Added doc for cgroups devices isolator.

2017-10-13 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62965/#review187943
---



Bad patch!

Reviews applied: [62965, 62959]

Failed command: python support/apply-reviews.py -n -r 62965

Error:
2017-10-13 08:50:11 URL:https://reviews.apache.org/r/62965/diff/raw/ 
[2897/2897] -> "62965.patch" [1]
error: patch failed: docs/mesos-containerizer.md:31
error: docs/mesos-containerizer.md: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/19779/console

- Mesos Reviewbot


On Oct. 13, 2017, 1:30 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62965/
> ---
> 
> (Updated Oct. 13, 2017, 1:30 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added doc for cgroups devices isolator.
> 
> 
> Diffs
> -
> 
>   docs/isolators/cgroups-devices.md PRE-CREATION 
>   docs/mesos-containerizer.md 4c82474cd748abf6490fec51c8146fa8b8345906 
> 
> 
> Diff: https://reviews.apache.org/r/62965/diff/2/
> 
> 
> Testing
> ---
> 
> https://github.com/jieyu/mesos/blob/doc/docs/isolators/cgroups-devices.md
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62965: Added doc for cgroups devices isolator.

2017-10-12 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62965/#review187930
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\apply-reviews.py -n -r 62965`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62965

Relevant logs:

- 
[apply-review-62965-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62965/logs/apply-review-62965-stdout.log):

```
error: patch failed: docs/mesos-containerizer.md:31
error: docs/mesos-containerizer.md: patch does not apply
```

- Mesos Reviewbot Windows


On Oct. 13, 2017, 4:30 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62965/
> ---
> 
> (Updated Oct. 13, 2017, 4:30 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added doc for cgroups devices isolator.
> 
> 
> Diffs
> -
> 
>   docs/isolators/cgroups-devices.md PRE-CREATION 
>   docs/mesos-containerizer.md 4c82474cd748abf6490fec51c8146fa8b8345906 
> 
> 
> Diff: https://reviews.apache.org/r/62965/diff/2/
> 
> 
> Testing
> ---
> 
> https://github.com/jieyu/mesos/blob/doc/docs/isolators/cgroups-devices.md
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 62965: Added doc for cgroups devices isolator.

2017-10-12 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62965/
---

(Updated Oct. 13, 2017, 1:30 a.m.)


Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.


Repository: mesos


Description
---

Added doc for cgroups devices isolator.


Diffs (updated)
-

  docs/isolators/cgroups-devices.md PRE-CREATION 
  docs/mesos-containerizer.md 4c82474cd748abf6490fec51c8146fa8b8345906 


Diff: https://reviews.apache.org/r/62965/diff/2/

Changes: https://reviews.apache.org/r/62965/diff/1-2/


Testing
---

https://github.com/jieyu/mesos/blob/doc/docs/isolators/cgroups-devices.md


Thanks,

Jie Yu

Review Request 62965: Added doc for cgroups devices isolator.

2017-10-12 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62965/
---

Review request for mesos, Gilbert Song, Ilya Pronin, and James Peach.


Repository: mesos


Description
---

Added doc for cgroups devices isolator.


Diffs
-

  docs/isolators/cgroups-devices.md PRE-CREATION 


Diff: https://reviews.apache.org/r/62965/diff/1/


Testing
---

https://github.com/jieyu/mesos/blob/doc/docs/isolators/cgroups-devices.md


Thanks,

Jie Yu