Re: Review Request 63175: Do not generate UnavailableResources for inactive frameworks.

2017-11-17 Thread Jiang Yan Xu
> On Nov. 7, 2017, 5:09 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 319 (patched) > > > > > > I think this should be `connected`? > > > > Right now there's some con

Re: Review Request 63175: Do not generate UnavailableResources for inactive frameworks.

2017-11-17 Thread Jiang Yan Xu
> On Nov. 7, 2017, 5:09 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 319 (patched) > > > > > > I think this should be `connected`? > > > > Right now there's some con

Re: Review Request 63175: Do not generate UnavailableResources for inactive frameworks.

2017-11-07 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63175/#review190412 --- src/master/allocator/mesos/hierarchical.hpp Lines 319 (patched) <

Re: Review Request 63175: Do not generate UnavailableResources for inactive frameworks.

2017-11-07 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63175/#review190385 --- Fix it, then Ship it! src/master/allocator/mesos/hierarchical.

Re: Review Request 63175: Do not generate UnavailableResources for inactive frameworks.

2017-10-20 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63175/#review188824 --- PASS: Mesos patch 63175 was successfully built and tested. Review

Re: Review Request 63175: Do not generate UnavailableResources for inactive frameworks.

2017-10-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63175/#review188823 --- Patch looks great! Reviews applied: [63175] Passed command: expo

Review Request 63175: Do not generate UnavailableResources for inactive frameworks.

2017-10-19 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63175/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-8085 https://issues.apa