Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63434/#review190437 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 3, 2017,

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

> On Nov. 7, 2017, 2:22 p.m., Qian Zhang wrote: > > I think you need to do the similar changes to the `CheckInfo` message. > > Avinash sridharan wrote: > `CheckInfo` is specific to the `default-executor` and hence UCR. We don't > support IPv6 for CNI and hence UCR at this point, so hence

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

> On Nov. 7, 2017, 2:22 p.m., Qian Zhang wrote: > > I think you need to do the similar changes to the `CheckInfo` message. `CheckInfo` is specific to the `default-executor` and hence UCR. We don't support IPv6 for CNI and hence UCR at this point, so hence not adding this to `CheckInfo` at

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

> On Nov. 2, 2017, 6:48 p.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto > > Lines 512-516 (patched) > > > > > > When I see this enum, I have several questions, for example, "how this > > fits into

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63434/#review190303 --- I think you need to do the similar changes to the `CheckInfo`

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63434/#review190011 --- Patch looks great! Reviews applied: [63434] Passed command:

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63434/#review190004 --- PASS: Mesos patch 63434 was successfully built and tested.

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63434/ --- (Updated Nov. 3, 2017, 12:38 a.m.) Review request for mesos, Alexander

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

> On Nov. 2, 2017, 6:48 p.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto > > Lines 512-516 (patched) > > > > > > When I see this enum, I have several questions, for example, "how this > > fits into

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63434/#review189946 --- include/mesos/mesos.proto Lines 512-516 (patched)

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63434/#review189750 --- PASS: Mesos patch 63434 was successfully built and tested.

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63434/#review189693 --- Patch looks great! Reviews applied: [63434] Passed command:

Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63434/ --- Review request for mesos, Alexander Rukletsov, Qian Zhang, and Vinod Kone.