Re: Review Request 63523: Updated `Allocator::updateAllocation` to take `ResourceConversion`s.

> On Nov. 6, 2017, 3:03 p.m., Benjamin Bannier wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 5001-5003 (original), 5015-5017 (patched) > > > > > > This is weird now since `launch` is only used to

Re: Review Request 63523: Updated `Allocator::updateAllocation` to take `ResourceConversion`s.

> On Nov. 6, 2017, 3:03 p.m., Benjamin Bannier wrote: > > src/master/master.cpp > > Lines 4888-4889 (original) > > > > > > This is weird. Any idea why we did inject this information into > > allocators? Is there

Re: Review Request 63523: Updated `Allocator::updateAllocation` to take `ResourceConversion`s.

> On Nov. 6, 2017, 3:03 p.m., Benjamin Bannier wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 888-896 (original), 809-817 (patched) > > > > > > This could be more general, and I am not sure I agree

Re: Review Request 63523: Updated `Allocator::updateAllocation` to take `ResourceConversion`s.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63523/#review190160 --- Fix it, then Ship it!

Re: Review Request 63523: Updated `Allocator::updateAllocation` to take `ResourceConversion`s.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63523/#review190003 --- Bad patch! Reviews applied: [63523, 63511, 63485, 63484, 63483,

Re: Review Request 63523: Updated `Allocator::updateAllocation` to take `ResourceConversion`s.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63523/#review189969 --- FAIL: Failed to apply the dependent review: 59988. Failed

Review Request 63523: Updated `Allocator::updateAllocation` to take `ResourceConversion`s.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63523/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Gaston Kleiman,