Re: Review Request 63741: Fixed a bug in devolving framework subscription with suppressed roles.

2017-12-01 Thread Jiang Yan Xu
> On Nov. 21, 2017, 10:04 a.m., Alexander Rukletsov wrote: > > src/internal/devolve.cpp > > Lines 203-204 (patched) > > > > > > I believe we prefer writing `CopyFrom()` explicitly, no? > > Jiang Yan Xu wrote: >

Re: Review Request 63741: Fixed a bug in devolving framework subscription with suppressed roles.

2017-12-01 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63741/#review192503 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 28, 2017, 12

Re: Review Request 63741: Fixed a bug in devolving framework subscription with suppressed roles.

2017-12-01 Thread Alexander Rukletsov
> On Nov. 21, 2017, 6:04 p.m., Alexander Rukletsov wrote: > > src/internal/devolve.cpp > > Lines 203-204 (patched) > > > > > > I believe we prefer writing `CopyFrom()` explicitly, no? > > Jiang Yan Xu wrote: > I

Re: Review Request 63741: Fixed a bug in devolving framework subscription with suppressed roles.

2017-11-27 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63741/ --- (Updated Nov. 27, 2017, 4:29 p.m.) Review request for mesos and Alexander Rukle

Re: Review Request 63741: Fixed a bug in devolving framework subscription with suppressed roles.

2017-11-27 Thread Jiang Yan Xu
> On Nov. 21, 2017, 10:04 a.m., Alexander Rukletsov wrote: > > src/internal/devolve.cpp > > Lines 194-196 (original), 194-196 (patched) > > > > > > What about `evolve()`? > > Jiang Yan Xu wrote: > I suppose I ne

Re: Review Request 63741: Fixed a bug in devolving framework subscription with suppressed roles.

2017-11-27 Thread Jiang Yan Xu
> On Nov. 21, 2017, 10:04 a.m., Alexander Rukletsov wrote: > > src/internal/devolve.cpp > > Lines 194-196 (original), 194-196 (patched) > > > > > > What about `evolve()`? I suppose I need to handle it there too sinc

Re: Review Request 63741: Fixed a bug in devolving framework subscription with suppressed roles.

2017-11-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63741/#review191605 --- src/internal/devolve.cpp Lines 194-196 (original), 194-196 (patch