Re: Review Request 63843: Implemented a test of offer operation reconcilation.

2017-11-30 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63843/ --- (Updated Nov. 30, 2017, 5 p.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 63843: Implemented a test of offer operation reconcilation.

2017-11-29 Thread Jie Yu
> On Nov. 29, 2017, 3:09 a.m., Jie Yu wrote: > > src/tests/slave_tests.cpp > > Lines 8900-8923 (patched) > > > > > > It'll be nice to move this logic here to > > MockResourceProvider::operationFailed and call

Re: Review Request 63843: Implemented a test of offer operation reconcilation.

2017-11-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63843/#review192223 --- Ship it! Ship It! - Jie Yu On Nov. 29, 2017, 4:27 p.m.,

Re: Review Request 63843: Implemented a test of offer operation reconcilation.

2017-11-29 Thread Benjamin Bannier
> On Nov. 29, 2017, 4:09 a.m., Jie Yu wrote: > > src/tests/slave_tests.cpp > > Lines 8831-8839 (patched) > > > > > > Any reason these EXPECT are in the scope? I put these here since the framework's subscription

Re: Review Request 63843: Implemented a test of offer operation reconcilation.

2017-11-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63843/ --- (Updated Nov. 29, 2017, 5:27 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 63843: Implemented a test of offer operation reconcilation.

2017-11-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63843/#review192103 --- src/tests/slave_tests.cpp Lines 8831-8839 (patched)

Re: Review Request 63843: Implemented a test of offer operation reconcilation.

2017-11-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63843/ --- (Updated Nov. 28, 2017, 10:32 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 63843: Implemented a test of offer operation reconcilation.

2017-11-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63843/ --- (Updated Nov. 27, 2017, 3:55 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 63843: Implemented a test of offer operation reconcilation.

2017-11-24 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63843/ --- (Updated Nov. 24, 2017, 3:07 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 63843: Implemented a test of offer operation reconcilation.

2017-11-21 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63843/ --- (Updated Nov. 21, 2017, 10:09 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 63843: Implemented a test of offer operation reconcilation.

2017-11-17 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63843/ --- (Updated Nov. 17, 2017, 6:24 p.m.) Review request for mesos, Greg Mann, Jie

Review Request 63843: Implemented a test of offer operation reconcilation.

2017-11-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63843/ --- Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht. Repository: