Re: Review Request 63976: Modified `downgradeResources` to use protobuf reflection.

2018-01-02 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63976/ --- (Updated Jan. 2, 2018, 3:34 p.m.) Review request for mesos and Benjamin

Re: Review Request 63976: Modified `downgradeResources` to use protobuf reflection.

2018-01-02 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63976/ --- (Updated Jan. 2, 2018, 12:55 p.m.) Review request for mesos and Benjamin

Re: Review Request 63976: Modified `downgradeResources` to use protobuf reflection.

2018-01-02 Thread Michael Park
> On Dec. 20, 2017, 6:24 p.m., Benjamin Mahler wrote: > > src/common/resources_utils.hpp > > Line 175 (original), 175-176 (patched) > > > > > > s/does/do/? > > > > Maybe remove the first sentence and just

Re: Review Request 63976: Modified `downgradeResources` to use protobuf reflection.

2017-12-20 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63976/#review194206 --- Fix it, then Ship it! src/common/resources_utils.hpp Line 175

Review Request 63976: Modified `downgradeResources` to use protobuf reflection.

2017-11-20 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63976/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8221