Re: Review Request 64069: Ensured command executor always honors shutdown request.

2017-12-21 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64069/#review194337 --- Ship it! Ship It! - Andrei Budnik On Dec. 20, 2017, 8:14

Re: Review Request 64069: Ensured command executor always honors shutdown request.

2017-12-20 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64069/ --- (Updated Dec. 20, 2017, 8:14 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 64069: Ensured command executor always honors shutdown request.

2017-12-20 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64069/#review194257 --- PASS: Mesos patch 64069 was successfully built and tested.

Re: Review Request 64069: Ensured command executor always honors shutdown request.

2017-12-20 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64069/ --- (Updated Dec. 20, 2017, 4:07 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 64069: Ensured command executor always honors shutdown request.

2017-12-20 Thread Alexander Rukletsov
> On Dec. 15, 2017, 4:48 p.m., Vinod Kone wrote: > > src/launcher/executor.cpp > > Lines 768 (patched) > > > > > > Can you add a test for this? Writing test is tricky: our test harness does not allow to drop

Re: Review Request 64069: Ensured command executor always honors shutdown request.

2017-12-20 Thread Alexander Rukletsov
> On Dec. 18, 2017, 9:40 p.m., Vinod Kone wrote: > > What about the fix for other built-in executors (docker, default)? > > > > Also, this only seems to fix the shutdown path, what about kill task path? > > > > > > Regaring the fix for kill task when a task hasn't been launched from the > >

Re: Review Request 64069: Ensured command executor always honors shutdown request.

2017-12-20 Thread Alexander Rukletsov
> On Dec. 19, 2017, 3:25 p.m., Andrei Budnik wrote: > > src/launcher/executor.cpp > > Lines 768 (patched) > > > > > > Let's print warning message before terminating: > > ``` > > LOG(WARNING) << "Attempted to

Re: Review Request 64069: Ensured command executor always honors shutdown request.

2017-12-19 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64069/#review194147 --- src/launcher/executor.cpp Lines 768 (patched)

Re: Review Request 64069: Ensured command executor always honors shutdown request.

2017-12-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64069/#review194088 --- What about the fix for other built-in executors (docker,

Re: Review Request 64069: Ensured command executor always honors shutdown request.

2017-12-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64069/#review193931 --- src/launcher/executor.cpp Lines 768 (patched)

Re: Review Request 64069: Ensured command executor always honors shutdown request.

2017-12-15 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64069/ --- (Updated Dec. 15, 2017, 10:43 a.m.) Review request for mesos, Andrei Budnik,

Review Request 64069: Ensured command executor always honors shutdown request.

2017-11-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64069/ --- Review request for mesos, Andrei Budnik, Armand Grillet, and Vinod Kone.