Re: Review Request 64271: Added an unit test for docker image auto gc.

2017-12-06 Thread Gilbert Song
> On Dec. 3, 2017, 2:53 p.m., Zhitao Li wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp > > Lines 463 (patched) > > > > > > Indicate why this needs `ROOT_` permission? due to the chroot. all other

Re: Review Request 64271: Added an unit test for docker image auto gc.

2017-12-06 Thread Gilbert Song
> On Dec. 2, 2017, 1:27 a.m., Qian Zhang wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp > > Lines 561 (patched) > > > > > > Why calling `paths::listLayer()` again here? Can we directly check > >

Re: Review Request 64271: Added an unit test for docker image auto gc.

2017-12-06 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64271/ --- (Updated Dec. 6, 2017, 11:15 a.m.) Review request for mesos, Jie Yu, Qian

Re: Review Request 64271: Added an unit test for docker image auto gc.

2017-12-03 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64271/#review192667 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 64271: Added an unit test for docker image auto gc.

2017-12-03 Thread Zhitao Li
> On Dec. 3, 2017, 10:53 p.m., Zhitao Li wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp > > Lines 465 (patched) > > > > > > Why do we need a master? Never mind, I see we need to launch a task

Re: Review Request 64271: Added an unit test for docker image auto gc.

2017-12-03 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64271/#review192657 --- src/tests/containerizer/provisioner_docker_tests.cpp Lines 463

Re: Review Request 64271: Added an unit test for docker image auto gc.

2017-12-02 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64271/#review192625 --- Fix it, then Ship it!

Review Request 64271: Added an unit test for docker image auto gc.

2017-12-01 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64271/ --- Review request for mesos, Jie Yu, Qian Zhang, Vinod Kone, and Zhitao Li. Bugs: