Re: Review Request 64690: Windows: Removed manual use of `O_BINARY`.

2017-12-19 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64690/#review194175
---



PASS: Mesos patch 64690 was successfully built and tested.

Reviews applied: `['64689', '64690']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64690

- Mesos Reviewbot Windows


On Dec. 18, 2017, 10:35 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64690/
> ---
> 
> (Updated Dec. 18, 2017, 10:35 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Jeff Coffler, Gaston Kleiman, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-8347
> https://issues.apache.org/jira/browse/MESOS-8347
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is now superfluous as it is added in stout.
> 
> 
> Diffs
> -
> 
>   src/status_update_manager/status_update_manager_process.hpp 
> 5dc2bec14de972efa2dd00f9faf6c025f2e56e15 
> 
> 
> Diff: https://reviews.apache.org/r/64690/diff/2/
> 
> 
> Testing
> ---
> 
> `ctest -V -C Debug` on Windows 10.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>



Re: Review Request 64690: Windows: Removed manual use of `O_BINARY`.

2017-12-19 Thread Gaston Kleiman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64690/#review194166
---


Ship it!




Ship It!

- Gaston Kleiman


On Dec. 18, 2017, 7:35 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64690/
> ---
> 
> (Updated Dec. 18, 2017, 7:35 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Jeff Coffler, Gaston Kleiman, and 
> Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is now superfluous as it is added in stout.
> 
> 
> Diffs
> -
> 
>   src/status_update_manager/status_update_manager_process.hpp 
> 5dc2bec14de972efa2dd00f9faf6c025f2e56e15 
> 
> 
> Diff: https://reviews.apache.org/r/64690/diff/2/
> 
> 
> Testing
> ---
> 
> `ctest -V -C Debug` on Windows 10.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>



Re: Review Request 64690: Windows: Removed manual use of `O_BINARY`.

2017-12-19 Thread Jeff Coffler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64690/#review194165
---


Ship it!




Ship It!

- Jeff Coffler


On Dec. 19, 2017, 3:35 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64690/
> ---
> 
> (Updated Dec. 19, 2017, 3:35 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Jeff Coffler, Gaston Kleiman, and 
> Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is now superfluous as it is added in stout.
> 
> 
> Diffs
> -
> 
>   src/status_update_manager/status_update_manager_process.hpp 
> 5dc2bec14de972efa2dd00f9faf6c025f2e56e15 
> 
> 
> Diff: https://reviews.apache.org/r/64690/diff/2/
> 
> 
> Testing
> ---
> 
> `ctest -V -C Debug` on Windows 10.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>



Re: Review Request 64690: Windows: Removed manual use of `O_BINARY`.

2017-12-18 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64690/#review194125
---



FAIL: Mesos tests failed to build.

Reviews applied: `['64689', '64690']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64690

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64690/logs/mesos-tests-build-cmake-stdout.log):

```
  D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(75): 
warning C4267: '=': conversion from 'size_t' to 'unsigned long', possible loss 
of data [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(271): 
warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible 
loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(333): 
warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss 
of data [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(216): 
warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible 
loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(242): 
warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible 
loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(274): 
warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss 
of data [D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file D:\DCOS\mesos\mesos\src\common\protobuf_utils.cpp) 
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\files\files.cpp(704): warning C4267: 'argument': 
conversion from 'size_t' to 'off_t', possible loss of data 
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file D:\DCOS\mesos\mesos\src\master\master.cpp) 
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file D:\DCOS\mesos\mesos\src\master\quota_handler.cpp) 
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master\master.cpp(6223): warning C4244: 'argument': 
conversion from 'const ::size_t' to 'double', possible loss of data 
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master\master.cpp(6325): warning C4244: 'argument': 
conversion from 'const ::size_t' to 'double', possible loss of data 
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master\master.cpp(6890): warning C4244: 'argument': 
conversion from 'const ::size_t' to 'double', possible loss of data 
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': 
conversion from 'unsigned __int64' to 'double', possible loss of data 
(compiling source file D:\DCOS\mesos\mesos\src\master\weights_handler.cpp) 
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master\allocator\sorter\drf\sorter.cpp(589): warning 
C4267: 'return': conversion from 'size_t' to 'int', possible loss of data 
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master\master.cpp(9012): warning C4244: 'argument': 
conversion from 'const ::size_t' to 'double', possible loss of data 
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\src\master\master.cpp(10853): warning C4244: 'return': 
conversion from '::size_t' to 'double', possible loss of data 
[D:\DCOS\mesos\src\mesos.vcxproj]


"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (12) ->
(ClCompile target) -> 
  D:\DCOS\mesos\mesos\include\csi/spec.hpp(21): fatal error C1083: Cannot open 
include file: 'csi/csi.grpc.pb.h': No such file or directory (compiling source 
file D:\DCOS\mesos\mesos\src\slave\task_status_update_manager.cpp) 
[D:\DCOS\mesos\src\mesos.vcxproj]
  D:\DCOS\mesos\mesos\include\csi/spec.hpp(21): fatal error C1083: Cannot open 
include file: 'csi/csi.grpc.pb.h': No such file or directory (compiling source 
file D:\DCOS\mesos\mesos\src\slave\slave.cpp) [D:\DCOS\mesos\src\mesos.vcxproj]

132 Warning(s)
2 Error(s)

Time Elapsed 00:02:53.45
```

- 
[mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64690/logs/mesos-tests-CMakeOutput.log):


Review Request 64690: Windows: Removed manual use of `O_BINARY`.

2017-12-18 Thread Andrew Schwartzmeyer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64690/
---

Review request for mesos, Akash Gupta, Jeff Coffler, Gaston Kleiman, and Joseph 
Wu.


Repository: mesos


Description
---

This is now superfluous as it is added in stout.


Diffs
-

  src/status_update_manager/status_update_manager_process.hpp 
5dc2bec14de972efa2dd00f9faf6c025f2e56e15 


Diff: https://reviews.apache.org/r/64690/diff/1/


Testing
---

`ctest -V -C Debug` on Windows 10.


Thanks,

Andrew Schwartzmeyer