Re: Review Request 65070: Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.

2018-01-16 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65070/#review195465
---


Ship it!




Nice test!

- Vinod Kone


On Jan. 16, 2018, 3:33 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65070/
> ---
> 
> (Updated Jan. 16, 2018, 3:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gilbert Song, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-8279
> https://issues.apache.org/jira/browse/MESOS-8279
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> d2cf5fdda3c51d42548c102f076d2b4aebe1170b 
> 
> 
> Diff: https://reviews.apache.org/r/65070/diff/2/
> 
> 
> Testing
> ---
> 
> Manually ran this test 
> (`LauncherAndIsolationParam/PersistentVolumeDefaultExecutor.ROOT_TaskSandboxPersistentVolume/*`)
>  100 times.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 65070: Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.

2018-01-16 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65070/
---

(Updated Jan. 16, 2018, 11:33 p.m.)


Review request for mesos, Benjamin Mahler, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
---

Updated comments.


Bugs: MESOS-8279
https://issues.apache.org/jira/browse/MESOS-8279


Repository: mesos


Description
---

Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.


Diffs (updated)
-

  src/tests/default_executor_tests.cpp d2cf5fdda3c51d42548c102f076d2b4aebe1170b 


Diff: https://reviews.apache.org/r/65070/diff/2/

Changes: https://reviews.apache.org/r/65070/diff/1-2/


Testing
---

Manually ran this test 
(`LauncherAndIsolationParam/PersistentVolumeDefaultExecutor.ROOT_TaskSandboxPersistentVolume/*`)
 100 times.


Thanks,

Qian Zhang



Re: Review Request 65070: Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.

2018-01-16 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65070/
---

(Updated Jan. 16, 2018, 10:28 p.m.)


Review request for mesos, Benjamin Mahler, Gilbert Song, Jie Yu, and Vinod Kone.


Summary (updated)
-

Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.


Bugs: MESOS-8279
https://issues.apache.org/jira/browse/MESOS-8279


Repository: mesos


Description
---

Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.


Diffs
-

  src/tests/default_executor_tests.cpp d2cf5fdda3c51d42548c102f076d2b4aebe1170b 


Diff: https://reviews.apache.org/r/65070/diff/1/


Testing
---

Manually ran this test 
(`LauncherAndIsolationParam/PersistentVolumeDefaultExecutor.ROOT_TaskSandboxPersistentVolume/*`)
 100 times.


Thanks,

Qian Zhang



Review Request 65070: Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.

2018-01-10 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65070/
---

Review request for mesos, Benjamin Mahler, Gilbert Song, Jie Yu, and Vinod Kone.


Bugs: MESOS-8279
https://issues.apache.org/jira/browse/MESOS-8279


Repository: mesos


Description
---

Updated `ROOT_TaskSandboxPersistentVolume` to check `/files` endpoint.


Diffs
-

  src/tests/default_executor_tests.cpp d2cf5fdda3c51d42548c102f076d2b4aebe1170b 


Diff: https://reviews.apache.org/r/65070/diff/1/


Testing
---

Manually ran this test 
(`LauncherAndIsolationParam/PersistentVolumeDefaultExecutor.ROOT_TaskSandboxPersistentVolume/*`)
 100 times.


Thanks,

Qian Zhang