Re: Review Request 65106: Removed the misleading `isRemovable` helper in the master.

2018-01-22 Thread Benjamin Mahler
> On Jan. 23, 2018, 1:29 a.m., Vinod Kone wrote: > > src/master/master.cpp > > Lines 10170 (patched) > > > > > > s/Indicated/Indicates/ ? Oh, yeah this isn't my comment but I'll touch it up here since it's been

Re: Review Request 65106: Removed the misleading `isRemovable` helper in the master.

2018-01-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65106/#review195962 --- Fix it, then Ship it! src/master/master.cpp Lines 10170

Re: Review Request 65106: Removed the misleading `isRemovable` helper in the master.

2018-01-22 Thread Benjamin Mahler
> On Jan. 22, 2018, 8:02 p.m., Vinod Kone wrote: > > Thank you for the review! :) > On Jan. 22, 2018, 8:02 p.m., Vinod Kone wrote: > > src/master/master.hpp > > Lines 2208 (patched) > > > > > > can you use

Re: Review Request 65106: Removed the misleading `isRemovable` helper in the master.

2018-01-22 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65106/ --- (Updated Jan. 23, 2018, 12:11 a.m.) Review request for mesos, James Peach,

Re: Review Request 65106: Removed the misleading `isRemovable` helper in the master.

2018-01-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65106/#review195647 --- src/master/master.hpp Lines 2208 (patched)

Re: Review Request 65106: Removed the misleading `isRemovable` helper in the master.

2018-01-12 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65106/#review195349 --- Will need to rebase off of https://reviews.apache.org/r/64940/

Review Request 65106: Removed the misleading `isRemovable` helper in the master.

2018-01-11 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65106/ --- Review request for mesos, Vinod Kone and Jiang Yan Xu. Bugs: MESOS-8389