Re: Review Request 65112: Added documentation about standalone containers.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65112/#review217518
---


Ship it!




- Greg Mann


On Aug. 27, 2019, 6:47 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65112/
> ---
> 
> (Updated Aug. 27, 2019, 6:47 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This outlines some of the differences to expect from this
> new type of container and shows some example API calls.
> 
> 
> Diffs
> -
> 
>   docs/csi.md 4a8358177d5f8bf6d310655c463e684cb61b0f28 
>   docs/home.md ad19919ffc268d050976a926387ad55bea9be2f7 
>   docs/standalone-containers.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65112/diff/2/
> 
> 
> Testing
> ---
> 
> Previewed the docs via the website generator.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 65112: Added documentation about standalone containers.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65112/#review217469
---



Patch looks great!

Reviews applied: [65112]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 27, 2019, 6:47 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65112/
> ---
> 
> (Updated Aug. 27, 2019, 6:47 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This outlines some of the differences to expect from this
> new type of container and shows some example API calls.
> 
> 
> Diffs
> -
> 
>   docs/csi.md 4a8358177d5f8bf6d310655c463e684cb61b0f28 
>   docs/home.md ad19919ffc268d050976a926387ad55bea9be2f7 
>   docs/standalone-containers.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65112/diff/2/
> 
> 
> Testing
> ---
> 
> Previewed the docs via the website generator.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 65112: Added documentation about standalone containers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65112/
---

(Updated Aug. 27, 2019, 11:47 a.m.)


Review request for mesos, Chun-Hung Hsiao and Jie Yu.


Changes
---

Reviving this doc change


Repository: mesos


Description
---

This outlines some of the differences to expect from this
new type of container and shows some example API calls.


Diffs (updated)
-

  docs/csi.md 4a8358177d5f8bf6d310655c463e684cb61b0f28 
  docs/home.md ad19919ffc268d050976a926387ad55bea9be2f7 
  docs/standalone-containers.md PRE-CREATION 


Diff: https://reviews.apache.org/r/65112/diff/2/

Changes: https://reviews.apache.org/r/65112/diff/1-2/


Testing
---

Previewed the docs via the website generator.


Thanks,

Joseph Wu

Re: Review Request 65112: Added documentation about standalone containers.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65112/#review208380
---




docs/standalone-containers.md
Lines 140-142 (patched)


Could we also include response information for the happy case of KILL and 
REMOVE calls? Currently the doc only tells users what to expect in case of 
failure.


- Greg Mann


On Jan. 12, 2018, 1:51 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65112/
> ---
> 
> (Updated Jan. 12, 2018, 1:51 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This outlines some of the differences to expect from this
> new type of container and shows some example API calls.
> 
> 
> Diffs
> -
> 
>   docs/csi.md ace5bd4c4293747fffe9bc8dbcceaf34ce035f2f 
>   docs/home.md 4c1fb3738bc9cbb45e0bca65e0f5defaf8c33c0a 
>   docs/standalone-containers.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65112/diff/1/
> 
> 
> Testing
> ---
> 
> Previewed the docs via the website generator.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 65112: Added documentation about standalone containers.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65112/#review208324
---




docs/standalone-containers.md
Lines 68 (patched)


I think you can get rid of the '{' here?


- Greg Mann


On Jan. 12, 2018, 1:51 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65112/
> ---
> 
> (Updated Jan. 12, 2018, 1:51 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This outlines some of the differences to expect from this
> new type of container and shows some example API calls.
> 
> 
> Diffs
> -
> 
>   docs/csi.md ace5bd4c4293747fffe9bc8dbcceaf34ce035f2f 
>   docs/home.md 4c1fb3738bc9cbb45e0bca65e0f5defaf8c33c0a 
>   docs/standalone-containers.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65112/diff/1/
> 
> 
> Testing
> ---
> 
> Previewed the docs via the website generator.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 65112: Added documentation about standalone containers.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65112/#review205994
---



Patch looks great!

Reviews applied: [65112]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Jan. 12, 2018, 1:51 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65112/
> ---
> 
> (Updated Jan. 12, 2018, 1:51 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This outlines some of the differences to expect from this
> new type of container and shows some example API calls.
> 
> 
> Diffs
> -
> 
>   docs/csi.md ace5bd4c4293747fffe9bc8dbcceaf34ce035f2f 
>   docs/home.md 4c1fb3738bc9cbb45e0bca65e0f5defaf8c33c0a 
>   docs/standalone-containers.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65112/diff/1/
> 
> 
> Testing
> ---
> 
> Previewed the docs via the website generator.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 65112: Added documentation about standalone containers.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65112/#review205984
---



I noticed that e.g., the CSI documentation links to `standalone-container.md` 
which currently points nowhere. Could finalize and land this patch?

- Benjamin Bannier


On Jan. 12, 2018, 2:51 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65112/
> ---
> 
> (Updated Jan. 12, 2018, 2:51 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This outlines some of the differences to expect from this
> new type of container and shows some example API calls.
> 
> 
> Diffs
> -
> 
>   docs/csi.md ace5bd4c4293747fffe9bc8dbcceaf34ce035f2f 
>   docs/home.md 4c1fb3738bc9cbb45e0bca65e0f5defaf8c33c0a 
>   docs/standalone-containers.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65112/diff/1/
> 
> 
> Testing
> ---
> 
> Previewed the docs via the website generator.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 65112: Added documentation about standalone containers.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65112/#review203834
---




docs/home.md
Lines 56 (patched)


Seems we add "s" to the file name if there are multiple types under the 
same concept?


- Chun-Hung Hsiao


On Jan. 12, 2018, 1:51 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65112/
> ---
> 
> (Updated Jan. 12, 2018, 1:51 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This outlines some of the differences to expect from this
> new type of container and shows some example API calls.
> 
> 
> Diffs
> -
> 
>   docs/csi.md ace5bd4c4293747fffe9bc8dbcceaf34ce035f2f 
>   docs/home.md 4c1fb3738bc9cbb45e0bca65e0f5defaf8c33c0a 
>   docs/standalone-containers.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65112/diff/1/
> 
> 
> Testing
> ---
> 
> Previewed the docs via the website generator.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 65112: Added documentation about standalone containers.

[Joseph Wu]

> On Jan. 11, 2018, 5:59 p.m., Jie Yu wrote:
> > docs/standalone-containers.md
> > Lines 157 (patched)
> > 
> >
> > I don't think `REMOVE` is supported for standalone container for now.
> > 
> > Also, if the wait is called after the container terminates, the exit 
> > status won't be retrieved.

Ah right, I forgot that I haven't submitted this patch yet: 
https://reviews.apache.org/r/63829/


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65112/#review195280
---


On Jan. 11, 2018, 5:51 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65112/
> ---
> 
> (Updated Jan. 11, 2018, 5:51 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This outlines some of the differences to expect from this
> new type of container and shows some example API calls.
> 
> 
> Diffs
> -
> 
>   docs/csi.md ace5bd4c4293747fffe9bc8dbcceaf34ce035f2f 
>   docs/home.md 4c1fb3738bc9cbb45e0bca65e0f5defaf8c33c0a 
>   docs/standalone-containers.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65112/diff/1/
> 
> 
> Testing
> ---
> 
> Previewed the docs via the website generator.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 65112: Added documentation about standalone containers.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65112/#review195289
---



PASS: Mesos patch 65112 was successfully built and tested.

Reviews applied: `['65112']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65112

- Mesos Reviewbot Windows


On Jan. 12, 2018, 1:51 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65112/
> ---
> 
> (Updated Jan. 12, 2018, 1:51 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This outlines some of the differences to expect from this
> new type of container and shows some example API calls.
> 
> 
> Diffs
> -
> 
>   docs/csi.md ace5bd4c4293747fffe9bc8dbcceaf34ce035f2f 
>   docs/home.md 4c1fb3738bc9cbb45e0bca65e0f5defaf8c33c0a 
>   docs/standalone-containers.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65112/diff/1/
> 
> 
> Testing
> ---
> 
> Previewed the docs via the website generator.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 65112: Added documentation about standalone containers.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65112/#review195281
---



You may also want to mention that only MesosContainerizer supports standalone 
container currently

- Jie Yu


On Jan. 12, 2018, 1:51 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65112/
> ---
> 
> (Updated Jan. 12, 2018, 1:51 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This outlines some of the differences to expect from this
> new type of container and shows some example API calls.
> 
> 
> Diffs
> -
> 
>   docs/csi.md ace5bd4c4293747fffe9bc8dbcceaf34ce035f2f 
>   docs/home.md 4c1fb3738bc9cbb45e0bca65e0f5defaf8c33c0a 
>   docs/standalone-containers.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65112/diff/1/
> 
> 
> Testing
> ---
> 
> Previewed the docs via the website generator.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 65112: Added documentation about standalone containers.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65112/#review195280
---


Fix it, then Ship it!





docs/standalone-containers.md
Lines 157 (patched)


I don't think `REMOVE` is supported for standalone container for now.

Also, if the wait is called after the container terminates, the exit status 
won't be retrieved.



docs/standalone-containers.md
Lines 189 (patched)


standalone container's sandbox? I think the runtime directory will be gc'ed 
immediately


- Jie Yu


On Jan. 12, 2018, 1:51 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65112/
> ---
> 
> (Updated Jan. 12, 2018, 1:51 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This outlines some of the differences to expect from this
> new type of container and shows some example API calls.
> 
> 
> Diffs
> -
> 
>   docs/csi.md ace5bd4c4293747fffe9bc8dbcceaf34ce035f2f 
>   docs/home.md 4c1fb3738bc9cbb45e0bca65e0f5defaf8c33c0a 
>   docs/standalone-containers.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65112/diff/1/
> 
> 
> Testing
> ---
> 
> Previewed the docs via the website generator.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Review Request 65112: Added documentation about standalone containers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65112/
---

Review request for mesos, Chun-Hung Hsiao and Jie Yu.


Repository: mesos


Description
---

This outlines some of the differences to expect from this
new type of container and shows some example API calls.


Diffs
-

  docs/csi.md ace5bd4c4293747fffe9bc8dbcceaf34ce035f2f 
  docs/home.md 4c1fb3738bc9cbb45e0bca65e0f5defaf8c33c0a 
  docs/standalone-containers.md PRE-CREATION 


Diff: https://reviews.apache.org/r/65112/diff/1/


Testing
---

Previewed the docs via the website generator.


Thanks,

Joseph Wu