Re: Review Request 65149: MesosTidy: Enabled `mesos-this-capture`.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65149/#review195388
---


Fix it, then Ship it!





support/clang-tidy
Line 26 (original), 26 (patched)


We can just remove this line as `mesos-this-capture` is included in 
`mesos-*`.


- Benjamin Bannier


On Jan. 13, 2018, 6:32 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65149/
> ---
> 
> (Updated Jan. 13, 2018, 6:32 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MesosTidy: Enabled `mesos-this-capture`.
> 
> 
> Diffs
> -
> 
>   support/clang-tidy d68ddab6c796f1f583fb72ec06d6a91d845d1da9 
> 
> 
> Diff: https://reviews.apache.org/r/65149/diff/1/
> 
> 
> Testing
> ---
> 
> Ran `support/mesos-tidy.sh` and confirmed that the false positives have 
> disappeared.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 65149: MesosTidy: Enabled `mesos-this-capture`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65149/#review195386
---



PASS: Mesos patch 65149 was successfully built and tested.

Reviews applied: `['65149']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65149

- Mesos Reviewbot Windows


On Jan. 12, 2018, 9:32 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65149/
> ---
> 
> (Updated Jan. 12, 2018, 9:32 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MesosTidy: Enabled `mesos-this-capture`.
> 
> 
> Diffs
> -
> 
>   support/clang-tidy d68ddab6c796f1f583fb72ec06d6a91d845d1da9 
> 
> 
> Diff: https://reviews.apache.org/r/65149/diff/1/
> 
> 
> Testing
> ---
> 
> Ran `support/mesos-tidy.sh` and confirmed that the false positives have 
> disappeared.
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Review Request 65149: MesosTidy: Enabled `mesos-this-capture`.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65149/
---

Review request for mesos and Benjamin Bannier.


Repository: mesos


Description
---

MesosTidy: Enabled `mesos-this-capture`.


Diffs
-

  support/clang-tidy d68ddab6c796f1f583fb72ec06d6a91d845d1da9 


Diff: https://reviews.apache.org/r/65149/diff/1/


Testing
---

Ran `support/mesos-tidy.sh` and confirmed that the false positives have 
disappeared.


Thanks,

Michael Park