Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

2018-01-17 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65166/#review195654 --- Ship it! Ship It! - Andrew Schwartzmeyer On Jan. 17, 2018,

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

2018-01-17 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65166/#review195653 --- PASS: Mesos patch 65166 was successfully built and tested.

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

2018-01-17 Thread Andrew Schwartzmeyer
> On Jan. 17, 2018, 2:12 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/libprocess/src/tests/CMakeLists.txt > > Lines 98-101 (patched) > > > > > > Would you rather it be part of the `tests` target explicitly? You

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

2018-01-17 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65166/#review195651 --- 3rdparty/libprocess/src/tests/CMakeLists.txt Lines 98-101

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

2018-01-17 Thread Benjamin Bannier
> On Jan. 17, 2018, 7:58 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/tests/CMakeLists.txt > > Lines 91-93 (patched) > > > > > > We don't want to build this executable by default, so drop a > >

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

2018-01-17 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65166/ --- (Updated Jan. 17, 2018, 9:42 p.m.) Review request for mesos, Andrew

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

2018-01-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65166/#review195631 --- Fix it, then Ship it!

Re: Review Request 65166: Added libprocess benchmarks to cmake build setup.

2018-01-15 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65166/#review195418 --- PASS: Mesos patch 65166 was successfully built and tested.

Review Request 65166: Added libprocess benchmarks to cmake build setup.

2018-01-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65166/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos