Re: Review Request 65263: Updated `SlaveRecoveryTest.RecoverCompletedExecutor` to verify gc.

2018-01-22 Thread Qian Zhang
> On Jan. 23, 2018, 4:24 a.m., Vinod Kone wrote: > > Ship It! > > Vinod Kone wrote: > To confirm, would this new test have failed without the fix for > https://issues.apache.org/jira/browse/MESOS-8460 ? Actually no. The root cause of MESOS-8460 is we used a framework pointer after that fr

Re: Review Request 65263: Updated `SlaveRecoveryTest.RecoverCompletedExecutor` to verify gc.

2018-01-22 Thread Vinod Kone
> On Jan. 22, 2018, 8:24 p.m., Vinod Kone wrote: > > Ship It! To confirm, would this new test have failed without the fix for https://issues.apache.org/jira/browse/MESOS-8460 ? - Vinod --- This is an automatically generated e-mail. To

Re: Review Request 65263: Updated `SlaveRecoveryTest.RecoverCompletedExecutor` to verify gc.

2018-01-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65263/#review195932 --- Ship it! Ship It! - Vinod Kone On Jan. 22, 2018, 1:21 p.m.,

Re: Review Request 65263: Updated `SlaveRecoveryTest.RecoverCompletedExecutor` to verify gc.

2018-01-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65263/#review195908 --- PASS: Mesos patch 65263 was successfully built and tested. Review

Review Request 65263: Updated `SlaveRecoveryTest.RecoverCompletedExecutor` to verify gc.

2018-01-22 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65263/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-8462 https://issues.ap