Re: Review Request 65382: Reaped Docker executor only when it can be connected.

2018-01-30 Thread Qian Zhang
> On Jan. 31, 2018, 6:26 a.m., Vinod Kone wrote: > > The blocking review https://reviews.apache.org/r/65384/ seems non-existent? Yeah, that seems a bug in review board. So I posted it again as another patch: https://reviews.apache.org/r/65420/. - Qian

Re: Review Request 65382: Reaped Docker executor only when it can be connected.

2018-01-30 Thread Qian Zhang
> On Jan. 31, 2018, 6:25 a.m., Vinod Kone wrote: > > src/slave/containerizer/docker.cpp > > Lines 979 (patched) > > > > > > Do we return a "failed" container termination here? AFAICT, we return > > `None` on `wait`

Re: Review Request 65382: Reaped Docker executor only when it can be connected.

2018-01-30 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65382/ --- (Updated Jan. 31, 2018, 9:14 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 65382: Reaped Docker executor only when it can be connected.

2018-01-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65382/#review196538 --- The blocking review https://reviews.apache.org/r/65384/ seems

Re: Review Request 65382: Reaped Docker executor only when it can be connected.

2018-01-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65382/#review196536 --- Fix it, then Ship it! src/slave/containerizer/docker.cpp Line

Re: Review Request 65382: Reaped Docker executor only when it can be connected.

2018-01-30 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65382/ --- (Updated Jan. 30, 2018, 11:42 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 65382: Reaped Docker executor only when it can be connected.

2018-01-30 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65382/ --- (Updated Jan. 30, 2018, 11:35 p.m.) Review request for mesos and Vinod Kone.