Re: Review Request 65538: Added provider assignments into `disk_profile.proto`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/#review197016
---



FAIL: Failed to apply the dependent review: 65520.

Failed command: `python.exe .\support\apply-reviews.py -n -r 65520`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65538

Relevant logs:

- 
[apply-review-65520-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65538/logs/apply-review-65520-stdout.log):

```
error: patch failed: src/tests/storage_local_resource_provider_tests.cpp:73
error: src/tests/storage_local_resource_provider_tests.cpp: patch does not apply
```

- Mesos Reviewbot Windows


On Feb. 7, 2018, 6:51 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65538/
> ---
> 
> (Updated Feb. 7, 2018, 6:51 p.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A new `assignments` field is added to the `DiskProfileMapping` protobuf
> so that the URI disk profile adaptor can be customized to notify each
> resource provider a different set of profiles.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/disk_profile.proto 
> 6cf1f8abcd24e45a292efc95a395f90bb2140da2 
> 
> 
> Diff: https://reviews.apache.org/r/65538/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 65538: Added provider assignments into `disk_profile.proto`.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/#review197009
---


Fix it, then Ship it!




Can you update the summary and description of this review accordingly?


src/resource_provider/storage/disk_profile.proto
Line 32 (original), 51 (patched)


I don't change the tag number.


- Jie Yu


On Feb. 7, 2018, 6:51 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65538/
> ---
> 
> (Updated Feb. 7, 2018, 6:51 p.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
> 
> 
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A new `assignments` field is added to the `DiskProfileMapping` protobuf
> so that the URI disk profile adaptor can be customized to notify each
> resource provider a different set of profiles.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/disk_profile.proto 
> 6cf1f8abcd24e45a292efc95a395f90bb2140da2 
> 
> 
> Diff: https://reviews.apache.org/r/65538/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 65538: Added provider assignments into `disk_profile.proto`.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/
---

(Updated Feb. 7, 2018, 6:51 p.m.)


Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.


Changes
---

Addressed James' comment.


Summary (updated)
-

Added provider assignments into `disk_profile.proto`.


Bugs: MESOS-8510
https://issues.apache.org/jira/browse/MESOS-8510


Repository: mesos


Description
---

A new `assignments` field is added to the `DiskProfileMapping` protobuf
so that the URI disk profile adaptor can be customized to notify each
resource provider a different set of profiles.


Diffs (updated)
-

  src/resource_provider/storage/disk_profile.proto 
6cf1f8abcd24e45a292efc95a395f90bb2140da2 


Diff: https://reviews.apache.org/r/65538/diff/4/

Changes: https://reviews.apache.org/r/65538/diff/3-4/


Testing
---


Thanks,

Chun-Hung Hsiao