Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/#review197497 --- Ship it! Ship It! - Qian Zhang On Feb. 13, 2018, 7:41 a.m.,

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/#review197490 --- src/launcher/default_executor.cpp Line 791 (original), 794

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/ --- (Updated Feb. 12, 2018, 3:41 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

> On Feb. 12, 2018, 12:37 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp > > Line 786 (original), 788 (patched) > > > > > > If a launch for nested container fails, don't we get `NotFound`? This

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

> On Feb. 12, 2018, 11:57 a.m., Joseph Wu wrote: > > src/launcher/default_executor.cpp > > Line 1479 (original), 1492 (patched) > > > > > > This booleans seems like a remnant of the time when the default > >

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/#review197314 --- src/launcher/default_executor.cpp Line 786 (original), 788

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

> On Feb. 12, 2018, 7:57 p.m., Joseph Wu wrote: > > src/launcher/default_executor.cpp > > Line 1479 (original), 1492 (patched) > > > > > > This booleans seems like a remnant of the time when the default > >

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/#review197298 --- Mostly LGTM... some suggestions:

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/ --- (Updated Feb. 9, 2018, 10:35 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/ --- (Updated Feb. 9, 2018, 5:37 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/#review197021 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 65551: Stopped shutting down the whole default executor on task launch failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65551/ --- Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone.