Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

2018-11-07 Thread Jason Lai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/
---

(Updated Nov. 7, 2018, 9:23 p.m.)


Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, James Peach, and 
Zhitao Li.


Changes
---

Rebased to master


Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257


Repository: mesos


Description
---

Added an overloaded version of `os::realpath` to stout.

The new `os::realpath` function is used for evaluating real path
within a scoped root directory.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/posix/realpath.hpp 
31352cefc5b8d0ccd9af8f6dabdec4a959fded32 


Diff: https://reviews.apache.org/r/65812/diff/8/

Changes: https://reviews.apache.org/r/65812/diff/7-8/


Testing
---


Thanks,

Jason Lai

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

2018-09-21 Thread Jason Lai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/
---

(Updated Sept. 21, 2018, 10:45 p.m.)


Review request for mesos, Eric Chung, Gilbert Song, Jie Yu, James Peach, and 
Zhitao Li.


Changes
---

Address review comments from @jieyu.


Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257


Repository: mesos


Description
---

Added an overloaded version of `os::realpath` to stout.

The new `os::realpath` function is used for evaluating real path
within a scoped root directory.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/posix/realpath.hpp 
31352cefc5b8d0ccd9af8f6dabdec4a959fded32 


Diff: https://reviews.apache.org/r/65812/diff/7/

Changes: https://reviews.apache.org/r/65812/diff/6-7/


Testing
---


Thanks,

Jason Lai

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

2018-09-21 Thread Jason Lai 


> On May 18, 2018, 10:12 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 68-81 (patched)
> > 
> >
> > IN fact, I would consider making `unprocessed` a `vector` 
> > (which is a result of `tokenize`)
> > 
> > I understand you want to reset `unprocessed` below, you can still do 
> > one more `tokenize` there to avoid the complex substr logic here.

I tried with a local rewritten version per your suggestion, but it actually 
turned out to be a bit more complex and added perf overhead to this version.

We simply need to split `unprocessed` into 0 up to 2 elements and the logic 
seems pretty intuitive here.


- Jason


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review203455
---


On May 17, 2018, 1:07 a.m., Jason Lai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> ---
> 
> (Updated May 17, 2018, 1:07 a.m.)
> 
> 
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, 
> James Peach, and Zhitao Li.
> 
> 
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an overloaded version of `os::realpath` to stout.
> 
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/posix/realpath.hpp 
> 31352cefc5b8d0ccd9af8f6dabdec4a959fded32 
> 
> 
> Diff: https://reviews.apache.org/r/65812/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Lai
> 
>

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

2018-09-21 Thread Jason Lai 


> On May 18, 2018, 10:08 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 51 (patched)
> > 
> >
> > Any reason we need this parameter here? Can we just remove this 
> > parameter, and use `os::PATH_SEPARATOR` below?

Done.


> On May 18, 2018, 10:08 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 65 (patched)
> > 
> >
> > No need for period for error messages.

Done


> On May 18, 2018, 10:08 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 88 (patched)
> > 
> >
> > No need to specify `_separator`?

Dropped.


> On May 18, 2018, 10:08 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 99 (patched)
> > 
> >
> > no need to specify `_separator` for both functions. They're the default 
> > value

Dropped.


> On May 18, 2018, 10:08 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 108-112 (patched)
> > 
> >
> > Let's add a stout helper `os::readlink`:
> > 
> > ```
> > Try readlink(const string& path);
> > ```

I added https://reviews.apache.org/r/68804/ as the wrapper for this.


> On May 18, 2018, 10:08 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 130 (patched)
> > 
> >
> > Ditto. No need for `_separator`

Dropped.


- Jason


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review203430
---


On May 17, 2018, 1:07 a.m., Jason Lai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> ---
> 
> (Updated May 17, 2018, 1:07 a.m.)
> 
> 
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, 
> James Peach, and Zhitao Li.
> 
> 
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an overloaded version of `os::realpath` to stout.
> 
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/posix/realpath.hpp 
> 31352cefc5b8d0ccd9af8f6dabdec4a959fded32 
> 
> 
> Diff: https://reviews.apache.org/r/65812/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Lai
> 
>

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

2018-05-18 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review203455
---




3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 68-81 (patched)


IN fact, I would consider making `unprocessed` a `vector` (which is 
a result of `tokenize`)

I understand you want to reset `unprocessed` below, you can still do one 
more `tokenize` there to avoid the complex substr logic here.


- Jie Yu


On May 17, 2018, 1:07 a.m., Jason Lai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> ---
> 
> (Updated May 17, 2018, 1:07 a.m.)
> 
> 
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, 
> James Peach, and Zhitao Li.
> 
> 
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an overloaded version of `os::realpath` to stout.
> 
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/posix/realpath.hpp 
> 31352cefc5b8d0ccd9af8f6dabdec4a959fded32 
> 
> 
> Diff: https://reviews.apache.org/r/65812/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Lai
> 
>

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

2018-05-18 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review203430
---




3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 51 (patched)


Any reason we need this parameter here? Can we just remove this parameter, 
and use `os::PATH_SEPARATOR` below?



3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 65 (patched)


No need for period for error messages.



3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 88 (patched)


No need to specify `_separator`?



3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 98-99 (patched)


Hum, consider this case:

```
path="/rootfs/bar"
root="/rootfs"
```
I was expecting the correct result to be `"/rootfs/bar"` (if I understand 
your function parameter correctly, if not, can you add more description for the 
parameters?)

Assuming that there's a symlink in the rootfs `/rootfs/rootfs -> /foo` 
(symlink).

When we process `"rootfs"` here (i.e., `component`), `normalizedPath == 
"/rootfs"`, and `fullPath == "/rootfs/rootfs"`. Since `/rootfs/rootfs` is a 
symlink, `linkPath` will be `"/foo"`. `"unprocessed"` will become `"/foo/bar"`.

Maybe the parameter `path` is scoped in the `root`? If that's the case, can 
you improve the function comments with more examples?



3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 99 (patched)


no need to specify `_separator` for both functions. They're the default 
value



3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 102-107 (patched)


you can use `os::stat::islink` here



3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 108-112 (patched)


Let's add a stout helper `os::readlink`:

```
Try readlink(const string& path);
```



3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 130 (patched)


Ditto. No need for `_separator`


- Jie Yu


On May 17, 2018, 1:07 a.m., Jason Lai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> ---
> 
> (Updated May 17, 2018, 1:07 a.m.)
> 
> 
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, 
> James Peach, and Zhitao Li.
> 
> 
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an overloaded version of `os::realpath` to stout.
> 
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/posix/realpath.hpp 
> 31352cefc5b8d0ccd9af8f6dabdec4a959fded32 
> 
> 
> Diff: https://reviews.apache.org/r/65812/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Lai
> 
>

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

2018-05-18 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review203454
---



It's very hard to reason about the correctness of this patch without seeing 
thorough testing. Please include tests!

- Jie Yu


On May 17, 2018, 1:07 a.m., Jason Lai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> ---
> 
> (Updated May 17, 2018, 1:07 a.m.)
> 
> 
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, 
> James Peach, and Zhitao Li.
> 
> 
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an overloaded version of `os::realpath` to stout.
> 
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/posix/realpath.hpp 
> 31352cefc5b8d0ccd9af8f6dabdec4a959fded32 
> 
> 
> Diff: https://reviews.apache.org/r/65812/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Lai
> 
>

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

2018-05-16 Thread Jason Lai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/
---

(Updated May 17, 2018, 1:07 a.m.)


Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James 
Peach, and Zhitao Li.


Changes
---

Rebased to the latest `master` branch.


Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257


Repository: mesos


Description
---

Added an overloaded version of `os::realpath` to stout.

The new `os::realpath` function is used for evaluating real path
within a scoped root directory.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/posix/realpath.hpp 
31352cefc5b8d0ccd9af8f6dabdec4a959fded32 


Diff: https://reviews.apache.org/r/65812/diff/6/

Changes: https://reviews.apache.org/r/65812/diff/5-6/


Testing
---


Thanks,

Jason Lai

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

2018-05-08 Thread Jason Lai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/
---

(Updated May 8, 2018, 6:43 p.m.)


Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James 
Peach, and Zhitao Li.


Changes
---

Rename `path::clean` to `path::normalize`.


Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257


Repository: mesos


Description
---

Added an overloaded version of `os::realpath` to stout.

The new `os::realpath` function is used for evaluating real path
within a scoped root directory.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/posix/realpath.hpp 
31352cefc5b8d0ccd9af8f6dabdec4a959fded32 


Diff: https://reviews.apache.org/r/65812/diff/5/

Changes: https://reviews.apache.org/r/65812/diff/4-5/


Testing
---


Thanks,

Jason Lai

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

2018-03-18 Thread Jason Lai 


> On March 16, 2018, 11:20 p.m., Jie Yu wrote:
> > 3rdparty/stout/include/stout/os/posix/realpath.hpp
> > Lines 48 (patched)
> > 
> >
> > Please add unit test for this.

Will do in a separate patch.


- Jason


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review199365
---


On March 5, 2018, 7:29 a.m., Jason Lai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> ---
> 
> (Updated March 5, 2018, 7:29 a.m.)
> 
> 
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, 
> James Peach, and Zhitao Li.
> 
> 
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an overloaded version of `os::realpath` to stout.
> 
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/posix/realpath.hpp 
> 31352cefc5b8d0ccd9af8f6dabdec4a959fded32 
> 
> 
> Diff: https://reviews.apache.org/r/65812/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Lai
> 
>

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

2018-03-16 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review199365
---




3rdparty/stout/include/stout/os/posix/realpath.hpp
Lines 48 (patched)


Please add unit test for this.


- Jie Yu


On March 5, 2018, 7:29 a.m., Jason Lai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> ---
> 
> (Updated March 5, 2018, 7:29 a.m.)
> 
> 
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, 
> James Peach, and Zhitao Li.
> 
> 
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an overloaded version of `os::realpath` to stout.
> 
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/posix/realpath.hpp 
> 31352cefc5b8d0ccd9af8f6dabdec4a959fded32 
> 
> 
> Diff: https://reviews.apache.org/r/65812/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Lai
> 
>

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

2018-03-04 Thread Jason Lai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/
---

(Updated March 5, 2018, 7:29 a.m.)


Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James 
Peach, and Zhitao Li.


Changes
---

Add `static` to the constant of `MAX_SYMLINKS`.


Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257


Repository: mesos


Description
---

Added an overloaded version of `os::realpath` to stout.

The new `os::realpath` function is used for evaluating real path
within a scoped root directory.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/posix/realpath.hpp 
31352cefc5b8d0ccd9af8f6dabdec4a959fded32 


Diff: https://reviews.apache.org/r/65812/diff/4/

Changes: https://reviews.apache.org/r/65812/diff/3-4/


Testing
---


Thanks,

Jason Lai

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

2018-03-02 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review198579
---



Patch looks great!

Reviews applied: [65811, 65812]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 2, 2018, 7:41 p.m., Jason Lai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> ---
> 
> (Updated March 2, 2018, 7:41 p.m.)
> 
> 
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, 
> James Peach, and Zhitao Li.
> 
> 
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an overloaded version of `os::realpath` to stout.
> 
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/posix/realpath.hpp 
> 31352cefc5b8d0ccd9af8f6dabdec4a959fded32 
> 
> 
> Diff: https://reviews.apache.org/r/65812/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Lai
> 
>

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

2018-03-02 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review198552
---



PASS: Mesos patch 65812 was successfully built and tested.

Reviews applied: `['65811', '65812']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65812

- Mesos Reviewbot Windows


On March 2, 2018, 7:41 p.m., Jason Lai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65812/
> ---
> 
> (Updated March 2, 2018, 7:41 p.m.)
> 
> 
> Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, 
> James Peach, and Zhitao Li.
> 
> 
> Bugs: MESOS-8257
> https://issues.apache.org/jira/browse/MESOS-8257
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an overloaded version of `os::realpath` to stout.
> 
> The new `os::realpath` function is used for evaluating real path
> within a scoped root directory.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/posix/realpath.hpp 
> 31352cefc5b8d0ccd9af8f6dabdec4a959fded32 
> 
> 
> Diff: https://reviews.apache.org/r/65812/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Lai
> 
>

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

2018-03-02 Thread Jason Lai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/
---

(Updated March 2, 2018, 7:41 p.m.)


Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James 
Peach, and Zhitao Li.


Changes
---

Use `inline` for the overloaded `os::realpath`.


Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257


Repository: mesos


Description
---

Added an overloaded version of `os::realpath` to stout.

The new `os::realpath` function is used for evaluating real path
within a scoped root directory.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/posix/realpath.hpp 
31352cefc5b8d0ccd9af8f6dabdec4a959fded32 


Diff: https://reviews.apache.org/r/65812/diff/3/

Changes: https://reviews.apache.org/r/65812/diff/2-3/


Testing
---


Thanks,

Jason Lai

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

2018-02-27 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review198342
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65811', '65812']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65812

Relevant logs:

- 
[stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65812/logs/stout-tests-cmake-stdout.log):

```
 CUSTOMBUILD : CMake warning :  
[D:\DCOS\mesos\3rdparty\zlib-1.2.8.vcxproj]


   "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default 
target) (1) ->
   "D:\DCOS\mesos\3rdparty\curl-7.57.0.vcxproj" (default target) (7) ->
 CUSTOMBUILD : CMake warning :  
[D:\DCOS\mesos\3rdparty\curl-7.57.0.vcxproj]


   "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default 
target) (1) ->
   (Link target) -> 
 ip_tests.obj : error LNK2005: "class std::basic_string __cdecl path::clean(class 
std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 mac_tests.obj : error LNK2005: "class std::basic_string __cdecl path::clean(class 
std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 main.obj : error LNK2005: "class std::basic_string __cdecl path::clean(class 
std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 os_tests.obj : error LNK2005: "class std::basic_string __cdecl path::clean(class 
std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 path_tests.obj : error LNK2005: "class std::basic_string __cdecl path::clean(class 
std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 subcommand_tests.obj : error LNK2005: "class 
std::basic_string __cdecl path::clean(class std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 copyfile_tests.obj : error LNK2005: "class 
std::basic_string __cdecl path::clean(class std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 env_tests.obj : error LNK2005: "class std::basic_string __cdecl path::clean(class 
std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 filesystem_tests.obj : error LNK2005: "class 
std::basic_string __cdecl path::clean(class std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 process_tests.obj : error LNK2005: "class 
std::basic_string

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout

2018-02-27 Thread Jason Lai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/
---

(Updated Feb. 27, 2018, 7:05 p.m.)


Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James 
Peach, and Zhitao Li.


Summary (updated)
-

Added an overloaded version of `os::realpath` to stout


Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257


Repository: mesos


Description (updated)
---

Added an overloaded version of `os::realpath` to stout.

The new `os::realpath` function is used for evaluating real path
within a scoped root directory.


Diffs
-

  3rdparty/stout/include/stout/os/posix/realpath.hpp 
31352cefc5b8d0ccd9af8f6dabdec4a959fded32 


Diff: https://reviews.apache.org/r/65812/diff/2/


Testing
---


Thanks,

Jason Lai

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout for evaluating real path within a scoped root directory

2018-02-27 Thread Jason Lai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/
---

(Updated Feb. 27, 2018, 7:04 p.m.)


Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James 
Peach, and Zhitao Li.


Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257


Repository: mesos


Description (updated)
---

Added an overloaded version of `os::realpath` to stout for evaluating real path 
within a scoped root directory.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/posix/realpath.hpp 
31352cefc5b8d0ccd9af8f6dabdec4a959fded32 


Diff: https://reviews.apache.org/r/65812/diff/2/

Changes: https://reviews.apache.org/r/65812/diff/1-2/


Testing
---


Thanks,

Jason Lai

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout for evaluating real path within a scoped root directory

2018-02-26 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review198317
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65811', '65812']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65812

Relevant logs:

- 
[stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65812/logs/stout-tests-cmake-stdout.log):

```
 CUSTOMBUILD : CMake warning :  
[D:\DCOS\mesos\3rdparty\zlib-1.2.8.vcxproj]


   "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default 
target) (1) ->
   "D:\DCOS\mesos\3rdparty\curl-7.57.0.vcxproj" (default target) (6) ->
 CUSTOMBUILD : CMake warning :  
[D:\DCOS\mesos\3rdparty\curl-7.57.0.vcxproj]


   "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default 
target) (1) ->
   (Link target) -> 
 ip_tests.obj : error LNK2005: "class std::basic_string __cdecl path::clean(class 
std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 mac_tests.obj : error LNK2005: "class std::basic_string __cdecl path::clean(class 
std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 main.obj : error LNK2005: "class std::basic_string __cdecl path::clean(class 
std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 os_tests.obj : error LNK2005: "class std::basic_string __cdecl path::clean(class 
std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 path_tests.obj : error LNK2005: "class std::basic_string __cdecl path::clean(class 
std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 subcommand_tests.obj : error LNK2005: "class 
std::basic_string __cdecl path::clean(class std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 copyfile_tests.obj : error LNK2005: "class 
std::basic_string __cdecl path::clean(class std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 env_tests.obj : error LNK2005: "class std::basic_string __cdecl path::clean(class 
std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 filesystem_tests.obj : error LNK2005: "class 
std::basic_string __cdecl path::clean(class std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 process_tests.obj : error LNK2005: "class 
std::basic_string

Review Request 65812: Added an overloaded version of `os::realpath` to stout for evaluating real path within a scoped root directory

2018-02-26 Thread Jason Lai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/
---

Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James 
Peach, and Zhitao Li.


Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257


Repository: mesos


Description
---

Added an overloaded version of `os::realpath` to stout for evaluating real path 
within a scoped root directory


Diffs
-

  3rdparty/stout/include/stout/os/posix/realpath.hpp 
31352cefc5b8d0ccd9af8f6dabdec4a959fded32 


Diff: https://reviews.apache.org/r/65812/diff/1/


Testing
---


Thanks,

Jason Lai