Re: Review Request 65832: Displayed resource provider resources in GET_RESOURCE_PROVIDER response.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65832/#review199484 --- Ship it! Ship It! - Greg Mann On Feb. 28, 2018, 12:55 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65832/ > --- > > (Updated Feb. 28, 2018, 12:55 p.m.) > > > Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-8388 > https://issues.apache.org/jira/browse/MESOS-8388 > > > Repository: mesos > > > Description > --- > > Displayed resource provider resources in GET_RESOURCE_PROVIDER response. > > > Diffs > - > > include/mesos/agent/agent.proto 7d92cb8e3dc533081d973e488bd140c7d5ea2bbf > include/mesos/v1/agent/agent.proto 59a9fd69df47c3605662529b5493cd3bf18c8397 > src/slave/http.cpp 7d7fa2b4ec2e1f8f65c5264ce72590d0d8195b9b > src/tests/api_tests.cpp e81d6ed25984c14e4143a048848c96e44e4f16e4 > > > Diff: https://reviews.apache.org/r/65832/diff/2/ > > > Testing > --- > > `make check` > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 65832: Displayed resource provider resources in GET_RESOURCE_PROVIDER response.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65832/#review199100 --- This API change looks good to me. Since this is a public API change, could you email the dev list and notify folks of the change (and the one in the subsequent patch as well)? - Greg Mann On Feb. 28, 2018, 12:55 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65832/ > --- > > (Updated Feb. 28, 2018, 12:55 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-8388 > https://issues.apache.org/jira/browse/MESOS-8388 > > > Repository: mesos > > > Description > --- > > Displayed resource provider resources in GET_RESOURCE_PROVIDER response. > > > Diffs > - > > include/mesos/agent/agent.proto 7d92cb8e3dc533081d973e488bd140c7d5ea2bbf > include/mesos/v1/agent/agent.proto 59a9fd69df47c3605662529b5493cd3bf18c8397 > src/slave/http.cpp 7d7fa2b4ec2e1f8f65c5264ce72590d0d8195b9b > src/tests/api_tests.cpp 9c172f751b11b3b50f23253d212c2eb603da9c2c > > > Diff: https://reviews.apache.org/r/65832/diff/1/ > > > Testing > --- > > `make check` > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 65832: Displayed resource provider resources in GET_RESOURCE_PROVIDER response.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65832/#review198446 --- Ship it! Ship It! - Jan Schlicht On Feb. 28, 2018, 1:55 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65832/ > --- > > (Updated Feb. 28, 2018, 1:55 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-8388 > https://issues.apache.org/jira/browse/MESOS-8388 > > > Repository: mesos > > > Description > --- > > Displayed resource provider resources in GET_RESOURCE_PROVIDER response. > > > Diffs > - > > include/mesos/agent/agent.proto 7d92cb8e3dc533081d973e488bd140c7d5ea2bbf > include/mesos/v1/agent/agent.proto 59a9fd69df47c3605662529b5493cd3bf18c8397 > src/slave/http.cpp 7d7fa2b4ec2e1f8f65c5264ce72590d0d8195b9b > src/tests/api_tests.cpp 9c172f751b11b3b50f23253d212c2eb603da9c2c > > > Diff: https://reviews.apache.org/r/65832/diff/1/ > > > Testing > --- > > `make check` > > > Thanks, > > Benjamin Bannier > >
Review Request 65832: Displayed resource provider resources in GET_RESOURCE_PROVIDER response.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65832/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8388 https://issues.apache.org/jira/browse/MESOS-8388 Repository: mesos Description --- Displayed resource provider resources in GET_RESOURCE_PROVIDER response. Diffs - include/mesos/agent/agent.proto 7d92cb8e3dc533081d973e488bd140c7d5ea2bbf include/mesos/v1/agent/agent.proto 59a9fd69df47c3605662529b5493cd3bf18c8397 src/slave/http.cpp 7d7fa2b4ec2e1f8f65c5264ce72590d0d8195b9b src/tests/api_tests.cpp 9c172f751b11b3b50f23253d212c2eb603da9c2c Diff: https://reviews.apache.org/r/65832/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier
