Re: Review Request 65940: Added test validating hierarchical role accounting.

2018-04-09 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65940/#review200790 --- PASS: Mesos patch 65940 was successfully built and tested.

Re: Review Request 65940: Added test validating hierarchical role accounting.

2018-04-09 Thread Till Toenshoff
> On April 6, 2018, 12:25 a.m., Kapil Arya wrote: > > This looks good to me. I am wondering if we need more test coverage for > > insertion/deletion of roles implicit roles. Perhaps a TODO? Yes, I was considering adding unit-tests for the `RoleTrackingTree` itself, that way we can avoid the

Re: Review Request 65940: Added test validating hierarchical role accounting.

2018-04-05 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65940/#review200609 --- Ship it! This looks good to me. I am wondering if we need more

Re: Review Request 65940: Added test validating hierarchical role accounting.

2018-04-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65940/#review200557 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65940: Added test validating hierarchical role accounting.

2018-04-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65940/ --- (Updated April 5, 2018, 4:15 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65940: Added test validating hierarchical role accounting.

2018-03-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65940/#review198774 --- Patch looks great! Reviews applied: [65939, 65940] Passed

Re: Review Request 65940: Added test validating hierarchical role accounting.

2018-03-06 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65940/#review198757 --- PASS: Mesos patch 65940 was successfully built and tested.

Review Request 65940: Added test validating hierarchical role accounting.

2018-03-06 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65940/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Kapil Arya, and