Re: Review Request 65959: Added a test to make sure `slave/recovery_time_secs` is reported.

2018-03-14 Thread James Peach

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65959/#review199196
---




src/tests/slave_tests.cpp
Lines 1377 (patched)


Nit:

```
// Make sure the agent finishes recovery.
```


- James Peach


On March 14, 2018, 6:03 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65959/
> ---
> 
> (Updated March 14, 2018, 6:03 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Jason Lai, and James Peach.
> 
> 
> Bugs: MESOS-8609
> https://issues.apache.org/jira/browse/MESOS-8609
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test to make sure `slave/recovery_time_secs` is reported.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp c2afaa573039e25fb59496765e6717e7643a692f 
> 
> 
> Diff: https://reviews.apache.org/r/65959/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>



Re: Review Request 65959: Added a test to make sure `slave/recovery_time_secs` is reported.

2018-03-14 Thread Zhitao Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65959/
---

(Updated March 14, 2018, 6:03 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Jason Lai, and James Peach.


Changes
---

Updated metric name.


Summary (updated)
-

Added a test to make sure `slave/recovery_time_secs` is reported.


Bugs: MESOS-8609
https://issues.apache.org/jira/browse/MESOS-8609


Repository: mesos


Description (updated)
---

Added a test to make sure `slave/recovery_time_secs` is reported.


Diffs (updated)
-

  src/tests/slave_tests.cpp c2afaa573039e25fb59496765e6717e7643a692f 


Diff: https://reviews.apache.org/r/65959/diff/2/

Changes: https://reviews.apache.org/r/65959/diff/1-2/


Testing
---


Thanks,

Zhitao Li