Re: Review Request 66007: CMake: Set C++11 as standard automatically.

2018-03-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66007/#review199343 --- Ship it! Ship It! - Joseph Wu On March 9, 2018, 2:37 p.m., A

Re: Review Request 66007: CMake: Set C++11 as standard automatically.

2018-03-14 Thread Andrew Schwartzmeyer
> On March 14, 2018, 9:32 a.m., Benjamin Bannier wrote: > > cmake/CompilationConfigure.cmake > > Lines 172 (patched) > > > > > > I am surprised that this does not disable permissive mode for msvc. Is > > that the ca

Re: Review Request 66007: CMake: Set C++11 as standard automatically.

2018-03-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66007/#review199177 --- Fix it, then Ship it! cmake/CompilationConfigure.cmake Lines 1

Re: Review Request 66007: CMake: Set C++11 as standard automatically.

2018-03-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66007/#review199157 --- Ship it! Ship It! - Michael Park On March 9, 2018, 2:37 p.m.

Re: Review Request 66007: CMake: Set C++11 as standard automatically.

2018-03-12 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66007/#review199029 --- Ship it! Ship It! - John Kordich On March 9, 2018, 10:37 p.m

Review Request 66007: CMake: Set C++11 as standard automatically.

2018-03-09 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66007/ --- Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John Kord