Re: Review Request 66088: Fixed crash on macOS during certain authorization calls.

2018-03-15 Thread Alexander Rojas
> On March 15, 2018, 3:36 p.m., Jan Schlicht wrote: > > src/common/http.cpp > > Lines 885-886 (original), 885-886 (patched) > > > > > > If it's the ordering of `ObjectApprovers` that's important, then we > >

Re: Review Request 66088: Fixed crash on macOS during certain authorization calls.

2018-03-15 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66088/#review199259 --- src/common/http.cpp Lines 885-886 (original), 885-886 (patched)

Re: Review Request 66088: Fixed crash on macOS during certain authorization calls.

2018-03-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66088/ --- (Updated March 15, 2018, 3:27 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 66088: Fixed crash on macOS during certain authorization calls.

2018-03-15 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66088/#review199258 --- Ship it! src/common/http.cpp Line 871 (original), 871

Review Request 66088: Fixed crash on macOS during certain authorization calls.

2018-03-15 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66088/ --- Review request for mesos, Benno Evers and Jan Schlicht. Bugs: MESOS-8677