----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66118/#review199599 -----------------------------------------------------------
Ship it! Ship It! - Greg Mann On March 16, 2018, 6:17 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66118/ > ----------------------------------------------------------- > > (Updated March 16, 2018, 6:17 p.m.) > > > Review request for mesos and Greg Mann. > > > Repository: mesos > > > Description > ------- > > The test `RemoveExecutorUponFailedTaskAuthorization` > currently depends on catching and modifying the input > arguments of agent `_run()` function to mock the > authorizer behavior. Using mock authorizer gives better > readability and more functionality. > > > Diffs > ----- > > src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19 > src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1 > src/tests/slave_tests.cpp f76500ebdb67f131a57a3b5aaae8c952d019e354 > > > Diff: https://reviews.apache.org/r/66118/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >