Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/ --- (Updated April 5, 2018, 3:35 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

> On April 2, 2018, 3:38 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Line 2166 (original), 2221-2227 (patched) > > > > > > Ah whoops, we should defer this continuation to `self()`. I think it's > > probably

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

> On April 2, 2018, 3:38 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Line 2166 (original), 2221-2227 (patched) > > > > > > Ah whoops, we should defer this continuation to `self()`. I think it's > > probably

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/ --- (Updated April 2, 2018, 5:33 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/ --- (Updated April 2, 2018, 10:57 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/#review200217 --- src/slave/slave.cpp Lines 2153-2201 (patched)

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/ --- (Updated March 27, 2018, 6:05 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/#review199858 --- src/slave/slave.cpp Lines 2174 (patched)

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/#review199824 --- Fix it, then Ship it! src/slave/slave.hpp Lines 176 (patched)

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

> On March 21, 2018, 11:37 a.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 2197-2199 (original), 2250-2252 (patched) > > > > > > Looks like you have an extra "because the framework" here. Also, this > >

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/ --- (Updated March 21, 2018, 2:49 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/#review199699 --- src/tests/slave_tests.cpp Lines 4698-4703 (original), 4696-4701

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/#review199477 --- src/slave/slave.hpp Lines 172-173 (original), 172-173 (patched)

Review Request 66126: Refactored agent task launch for better composition [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-8624