Re: Review Request 66218: Ensured that agent does not delete volume upon grow or shrink.

2018-04-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66218/#review201045 --- Ship it! Ship It! - Greg Mann On March 28, 2018, 6:25 p.m.,

Re: Review Request 66218: Ensured that agent does not delete volume upon grow or shrink.

2018-03-28 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66218/ --- (Updated March 28, 2018, 11:25 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66218: Ensured that agent does not delete volume upon grow or shrink.

2018-03-27 Thread Zhitao Li
> On March 27, 2018, 12:14 p.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 4169-4184 (patched) > > > > > > This is not a `set` operation but a `hashset` operation, so the > > comments are incorrect.

Re: Review Request 66218: Ensured that agent does not delete volume upon grow or shrink.

2018-03-27 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66218/ --- (Updated March 26, 2018, 11:36 p.m.) Review request for mesos, Chun-Hung

Re: Review Request 66218: Ensured that agent does not delete volume upon grow or shrink.

2018-03-26 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66218/#review200011 --- Fix it, then Ship it! src/slave/slave.cpp Line 4173

Review Request 66218: Ensured that agent does not delete volume upon grow or shrink.

2018-03-22 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66218/ --- Review request for mesos. Bugs: MESOS-4965