Re: Review Request 66234: Fixed variable shadowing in the default executor.

2018-03-27 Thread Gaston Kleiman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66234/
---

(Updated March 27, 2018, 9:43 a.m.)


Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
---

Fixed variable shadowing in the default executor.


Diffs
-

  src/launcher/default_executor.cpp 906836f3b8e0af79d7c61f90fd8a95f193b26e84 


Diff: https://reviews.apache.org/r/66234/diff/2/


Testing
---

`sudo bin/mesos-tests.sh` on GNU/Linux


Thanks,

Gaston Kleiman



Re: Review Request 66234: Fixed variable shadowing in the default executor.

2018-03-26 Thread Gaston Kleiman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66234/
---

(Updated March 26, 2018, 10:39 a.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Rebased.


Bugs: MESOS-8530
https://issues.apache.org/jira/browse/MESOS-8530


Repository: mesos


Description
---

Fixed variable shadowing in the default executor.


Diffs (updated)
-

  src/launcher/default_executor.cpp 906836f3b8e0af79d7c61f90fd8a95f193b26e84 


Diff: https://reviews.apache.org/r/66234/diff/2/

Changes: https://reviews.apache.org/r/66234/diff/1-2/


Testing
---

`sudo bin/mesos-tests.sh` on GNU/Linux


Thanks,

Gaston Kleiman



Re: Review Request 66234: Fixed variable shadowing in the default executor.

2018-03-26 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66234/#review199981
---


Ship it!




Ship It!

- Alexander Rukletsov


On March 23, 2018, 2:14 a.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66234/
> ---
> 
> (Updated March 23, 2018, 2:14 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-8530
> https://issues.apache.org/jira/browse/MESOS-8530
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed variable shadowing in the default executor.
> 
> 
> Diffs
> -
> 
>   src/launcher/default_executor.cpp 906836f3b8e0af79d7c61f90fd8a95f193b26e84 
> 
> 
> Diff: https://reviews.apache.org/r/66234/diff/1/
> 
> 
> Testing
> ---
> 
> `sudo bin/mesos-tests.sh` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>



Review Request 66234: Fixed variable shadowing in the default executor.

2018-03-22 Thread Gaston Kleiman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66234/
---

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-8530
https://issues.apache.org/jira/browse/MESOS-8530


Repository: mesos


Description
---

Fixed variable shadowing in the default executor.


Diffs
-

  src/launcher/default_executor.cpp 906836f3b8e0af79d7c61f90fd8a95f193b26e84 


Diff: https://reviews.apache.org/r/66234/diff/1/


Testing
---

`sudo bin/mesos-tests.sh` on GNU/Linux


Thanks,

Gaston Kleiman