Re: Review Request 66308: Delayed construction of the agent's resource provider manager.

2018-04-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66308/ --- (Updated April 20, 2018, 12:23 p.m.) Review request for mesos, Chun-Hung

Re: Review Request 66308: Delayed construction of the agent's resource provider manager.

2018-04-19 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66308/#review201605 --- src/slave/slave.cpp Lines 8849 (patched)

Re: Review Request 66308: Delayed construction of the agent's resource provider manager.

2018-04-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66308/ --- (Updated April 19, 2018, 11:19 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66308: Delayed construction of the agent's resource provider manager.

2018-04-19 Thread Benjamin Bannier
> On April 18, 2018, 8:58 p.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 839 (patched) > > > > > > One line apart. Actually, let's move this back to it's original place > > so all `/api/v1/*`

Re: Review Request 66308: Delayed construction of the agent's resource provider manager.

2018-04-18 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66308/#review201438 --- Fix it, then Ship it! src/slave/slave.cpp Lines 839 (patched)

Re: Review Request 66308: Delayed construction of the agent's resource provider manager.

2018-04-18 Thread Chun-Hung Hsiao
> On April 18, 2018, 3:03 a.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 8833-8840 (patched) > > > > > > There was a recent discussion in the API WG about adding routes > > dynamically (after

Re: Review Request 66308: Delayed construction of the agent's resource provider manager.

2018-04-18 Thread Benjamin Bannier
> On April 18, 2018, 5:03 a.m., Chun-Hung Hsiao wrote: > > src/slave/slave.hpp > > Line 815 (original), 819 (patched) > > > > > > This is inconsistent with the existing codebase. Could you justify why > > favoring

Re: Review Request 66308: Delayed construction of the agent's resource provider manager.

2018-04-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66308/ --- (Updated April 18, 2018, 4:28 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66308: Delayed construction of the agent's resource provider manager.

2018-04-17 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66308/#review201377 --- src/slave/slave.hpp Line 815 (original), 819 (patched)

Re: Review Request 66308: Delayed construction of the agent's resource provider manager.

2018-04-10 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66308/ --- (Updated April 10, 2018, 2:07 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 66308: Delayed construction of the agent's resource provider manager.

2018-03-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66308/ --- (Updated March 28, 2018, 4:28 p.m.) Review request for mesos, Jie Yu and Jan

Review Request 66308: Delayed construction of the agent's resource provider manager.

2018-03-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66308/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8735