Re: Review Request 66430: Windows: Fixed `os::dup()` to use `DuplicateHandle()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66430/#review201266 --- Ship it! - Joseph Wu On April 3, 2018, 10:50 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66430/ > --- > > (Updated April 3, 2018, 10:50 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8684 > https://issues.apache.org/jira/browse/MESOS-8684 > > > Repository: mesos > > > Description > --- > > Note that for now we need to keep the original CRT code, as it can't > be removed until `FD_CRT` is removed too. > > > Diffs > - > > 3rdparty/stout/include/stout/os/windows/dup.hpp > 265046cf7ffc14f7326711d295aa7dd4f0a8a1e3 > > > Diff: https://reviews.apache.org/r/66430/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 66430: Windows: Fixed `os::dup()` to use `DuplicateHandle()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66430/#review200598 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:50 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66430/ > --- > > (Updated April 4, 2018, 5:50 a.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8684 > https://issues.apache.org/jira/browse/MESOS-8684 > > > Repository: mesos > > > Description > --- > > Note that for now we need to keep the original CRT code, as it can't > be removed until `FD_CRT` is removed too. > > > Diffs > - > > 3rdparty/stout/include/stout/os/windows/dup.hpp > 265046cf7ffc14f7326711d295aa7dd4f0a8a1e3 > > > Diff: https://reviews.apache.org/r/66430/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 66430: Windows: Fixed `os::dup()` to use `DuplicateHandle()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66430/#review200511 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:50 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66430/ > --- > > (Updated April 4, 2018, 5:50 a.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8684 > https://issues.apache.org/jira/browse/MESOS-8684 > > > Repository: mesos > > > Description > --- > > Note that for now we need to keep the original CRT code, as it can't > be removed until `FD_CRT` is removed too. > > > Diffs > - > > 3rdparty/stout/include/stout/os/windows/dup.hpp > 265046cf7ffc14f7326711d295aa7dd4f0a8a1e3 > > > Diff: https://reviews.apache.org/r/66430/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Review Request 66430: Windows: Fixed `os::dup()` to use `DuplicateHandle()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66430/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park. Bugs: MESOS-8684 https://issues.apache.org/jira/browse/MESOS-8684 Repository: mesos Description --- Note that for now we need to keep the original CRT code, as it can't be removed until `FD_CRT` is removed too. Diffs - 3rdparty/stout/include/stout/os/windows/dup.hpp 265046cf7ffc14f7326711d295aa7dd4f0a8a1e3 Diff: https://reviews.apache.org/r/66430/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer
