Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/#review201763 --- Ship it! Ship It! - Greg Mann On April 23, 2018, 8:23 p.m.,

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/ --- (Updated April 23, 2018, 1:23 p.m.) Review request for mesos, Greg Mann and Vin

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/#review201682 --- include/mesos/v1/scheduler/scheduler.proto Lines 500 (patched)

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/#review201673 --- Changed the return type to the following proto message: ``` /**

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 6, 2018, 2:13 p.m., Vinod Kone wrote: > > include/mesos/v1/scheduler.hpp > > Line 50 (original), 54-55 (patched) > > > > > > Since we don't guarantee backwards compat for this library, can we just > > upda

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/ --- (Updated April 20, 2018, 5:03 p.m.) Review request for mesos, Greg Mann and Vin

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 10, 2018, 8:45 p.m., Benjamin Mahler wrote: > > include/mesos/v1/scheduler.hpp > > Lines 102-114 (patched) > > > > > > Hm.. why does this return an `Option`? > > > > If this is mesos Response rath

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 10, 2018, 1:45 p.m., Benjamin Mahler wrote: > > include/mesos/v1/scheduler.hpp > > Lines 102-114 (patched) > > > > > > Hm.. why does this return an `Option`? > > > > If this is mesos Response rath

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/ --- (Updated April 10, 2018, 7:25 p.m.) Review request for mesos, Greg Mann and Vin

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 10, 2018, 8:45 p.m., Benjamin Mahler wrote: > > include/mesos/v1/scheduler.hpp > > Lines 102-114 (patched) > > > > > > Hm.. why does this return an `Option`? > > > > If this is mesos Response rath

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 10, 2018, 8:45 p.m., Benjamin Mahler wrote: > > include/mesos/v1/scheduler.hpp > > Lines 102-114 (patched) > > > > > > Hm.. why does this return an `Option`? > > > > If this is mesos Response rath

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 10, 2018, 1:45 p.m., Benjamin Mahler wrote: > > include/mesos/v1/scheduler.hpp > > Lines 102-114 (patched) > > > > > > Hm.. why does this return an `Option`? > > > > If this is mesos Response rath

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 10, 2018, 8:45 p.m., Benjamin Mahler wrote: > > include/mesos/v1/scheduler.hpp > > Lines 102-114 (patched) > > > > > > Hm.. why does this return an `Option`? > > > > If this is mesos Response rath

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 10, 2018, 1:45 p.m., Benjamin Mahler wrote: > > include/mesos/v1/scheduler.hpp > > Lines 102-114 (patched) > > > > > > Hm.. why does this return an `Option`? > > > > If this is mesos Response rath

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/#review200842 --- include/mesos/v1/scheduler.hpp Lines 102-114 (patched)

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 6, 2018, 9:13 p.m., Vinod Kone wrote: > > include/mesos/v1/scheduler.hpp > > Line 50 (original), 54-55 (patched) > > > > > > Since we don't guarantee backwards compat for this library, can we just > > upda

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/ --- (Updated April 6, 2018, 2:17 p.m.) Review request for mesos and Greg Mann. Ch

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 6, 2018, 2:13 p.m., Vinod Kone wrote: > > include/mesos/v1/scheduler.hpp > > Line 50 (original), 54-55 (patched) > > > > > > Since we don't guarantee backwards compat for this library, can we just > > upda

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/#review200670 --- include/mesos/v1/scheduler.hpp Line 50 (original), 54-55 (patched

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/ --- (Updated April 6, 2018, 1:59 p.m.) Review request for mesos and Greg Mann. Ch

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 6, 2018, 1:24 p.m., Greg Mann wrote: > > src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp > > Lines 143 (patched) > > > > > > What do you think about using `LOG(FATAL)` here instead of > > `UNREACHA

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/#review200661 --- src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp Lines 143

Review Request 66460: Added a `call()` method to the v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/ --- Review request for mesos and Greg Mann. Repository: mesos Description ---