Re: Review Request 66621: Add alg RS256 support for JWT generator and validator.

2018-04-16 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66621/#review201217 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 66621: Add alg RS256 support for JWT generator and validator.

2018-04-16 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66621/#review201183 --- Looks great, thanks for adding this feature! Most issues are

Re: Review Request 66621: Add alg RS256 support for JWT generator and validator.

2018-04-16 Thread Clément Michaud
> On avr. 16, 2018, 9:25 matin, Alexander Rojas wrote: > > I haven't review it very thoroughly yet, but I found something that needs > > to be fixed. SSL support is an optional configurable feature (`--with-ssl` > > in the configure options). Since your patch depends on SSL, you need the > >

Re: Review Request 66621: Add alg RS256 support for JWT generator and validator.

2018-04-16 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66621/#review201187 --- I haven't review it very thoroughly yet, but I found something

Re: Review Request 66621: Add alg RS256 support for JWT generator and validator.

2018-04-14 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66621/#review201171 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 66621: Add alg RS256 support for JWT generator and validator.

2018-04-14 Thread Clément Michaud
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66621/ --- (Updated avr. 14, 2018, 10:19 après-midi) Review request for mesos. Bugs:

Review Request 66621: Add alg RS256 support for JWT generator and validator.

2018-04-14 Thread Clément Michaud
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66621/ --- Review request for mesos. Repository: mesos Description --- Add alg