Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.

2019-03-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66746/#review213669 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.

2019-02-26 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66746/#review213233 --- Bad review! Reviews applied: [66746] Error: 2019-02-26 21:33:43

Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.

2018-04-24 Thread Benjamin Mahler
> On April 24, 2018, 12:43 a.m., Benjamin Mahler wrote: > > I'm not sure this approach is tenable, we may in the future have two > > different `foo` fields with differing equality semantics. > > > > I was expecting that this patch would add an equality operator for specific > > types we want

Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.

2018-04-24 Thread Kapil Arya
> On April 23, 2018, 8:43 p.m., Benjamin Mahler wrote: > > I'm not sure this approach is tenable, we may in the future have two > > different `foo` fields with differing equality semantics. > > > > I was expecting that this patch would add an equality operator for specific > > types we want

Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.

2018-04-24 Thread Kapil Arya
> On April 23, 2018, 8:43 p.m., Benjamin Mahler wrote: > > I'm not sure this approach is tenable, we may in the future have two > > different `foo` fields with differing equality semantics. > > > > I was expecting that this patch would add an equality operator for specific > > types we want

Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.

2018-04-23 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66746/#review201799 --- I'm not sure this approach is tenable, we may in the future have

Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.

2018-04-20 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66746/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Repository: