Re: Review Request 66835: Replaced `int` and `HANDLE` types with `int_fd`.

2018-05-01 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66835/#review202227
---


Ship it!




Ship It!

- Joseph Wu


On April 26, 2018, 9:22 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66835/
> ---
> 
> (Updated April 26, 2018, 9:22 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced `int` and `HANDLE` types with `int_fd`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/launch.hpp 
> 0f66d6b49cbea9964457e890eff3cc7f1e058118 
> 
> 
> Diff: https://reviews.apache.org/r/66835/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>



Re: Review Request 66835: Replaced `int` and `HANDLE` types with `int_fd`.

2018-04-30 Thread Akash Gupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66835/#review202136
---


Ship it!




Ship It!

- Akash Gupta


On April 27, 2018, 4:22 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66835/
> ---
> 
> (Updated April 27, 2018, 4:22 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced `int` and `HANDLE` types with `int_fd`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/launch.hpp 
> 0f66d6b49cbea9964457e890eff3cc7f1e058118 
> 
> 
> Diff: https://reviews.apache.org/r/66835/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>



Re: Review Request 66835: Replaced `int` and `HANDLE` types with `int_fd`.

2018-04-27 Thread John Kordich via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66835/#review202087
---


Ship it!




Ship It!

- John Kordich


On April 27, 2018, 4:22 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66835/
> ---
> 
> (Updated April 27, 2018, 4:22 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced `int` and `HANDLE` types with `int_fd`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/launch.hpp 
> 0f66d6b49cbea9964457e890eff3cc7f1e058118 
> 
> 
> Diff: https://reviews.apache.org/r/66835/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>



Review Request 66835: Replaced `int` and `HANDLE` types with `int_fd`.

2018-04-26 Thread Andrew Schwartzmeyer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66835/
---

Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph Wu.


Repository: mesos


Description
---

Replaced `int` and `HANDLE` types with `int_fd`.


Diffs
-

  src/slave/containerizer/mesos/launch.hpp 
0f66d6b49cbea9964457e890eff3cc7f1e058118 


Diff: https://reviews.apache.org/r/66835/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer