Re: Review Request 66860: Avoid copying of register framework messages in the master.

2018-05-04 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66860/#review202483
---


Ship it!




Ship It!

- Benjamin Mahler


On May 4, 2018, 12:58 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66860/
> ---
> 
> (Updated May 4, 2018, 12:58 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8628
> https://issues.apache.org/jira/browse/MESOS-8628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Prior to this patch, the register framework message was copied
> into a subscribe call. This updates the handler to perform moves
> instead.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4 
>   src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
> 
> 
> Diff: https://reviews.apache.org/r/66860/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 66860: Avoid copying of register framework messages in the master.

2018-05-03 Thread Meng Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66860/
---

(Updated May 3, 2018, 5:58 p.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-8628
https://issues.apache.org/jira/browse/MESOS-8628


Repository: mesos


Description
---

Prior to this patch, the register framework message was copied
into a subscribe call. This updates the handler to perform moves
instead.


Diffs (updated)
-

  src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4 
  src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 


Diff: https://reviews.apache.org/r/66860/diff/3/

Changes: https://reviews.apache.org/r/66860/diff/2-3/


Testing
---

make check


Thanks,

Meng Zhu

Re: Review Request 66860: Avoid copying of register framework messages in the master.

2018-05-01 Thread Meng Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66860/
---

(Updated May 1, 2018, 4:44 p.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-8628
https://issues.apache.org/jira/browse/MESOS-8628


Repository: mesos


Description
---

Prior to this patch, the register framework message was copied
into a subscribe call. This updates the handler to perform moves
instead.


Diffs (updated)
-

  src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4 
  src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 


Diff: https://reviews.apache.org/r/66860/diff/2/

Changes: https://reviews.apache.org/r/66860/diff/1-2/


Testing
---

make check


Thanks,

Meng Zhu

Re: Review Request 66860: Avoid copying of register framework messages in the master.

2018-04-30 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66860/#review202179
---




src/master/master.cpp
Line 2488 (original), 2489 (patched)


I believe `std::move(const T& t)` will return `const T&&` at which point 
we're still copying it into the call?

This could be:

```
*call.mutable_framework_info() =
  std::move(*registerFrameworkMessage.mutable_framework());
  
// Or

FrameworkInfo frameworkInfo =
  std::move(*registerFrameworkMessage.mutable_framework());
  
...

*call.mutable_framework_info() = std::move(frameworkInfo);
```


- Benjamin Mahler


On April 30, 2018, 9:47 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66860/
> ---
> 
> (Updated April 30, 2018, 9:47 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8628
> https://issues.apache.org/jira/browse/MESOS-8628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Prior to this patch, the register framework message was copied
> into a subscribe call. This updates the handler to perform moves
> instead.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4 
>   src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
> 
> 
> Diff: https://reviews.apache.org/r/66860/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 66860: Avoid copying of register framework messages in the master.

2018-04-30 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66860/#review202165
---



PASS: Mesos patch 66860 was successfully built and tested.

Reviews applied: `['66860']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66860

- Mesos Reviewbot Windows


On April 30, 2018, 2:47 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66860/
> ---
> 
> (Updated April 30, 2018, 2:47 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8628
> https://issues.apache.org/jira/browse/MESOS-8628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Prior to this patch, the register framework message was copied
> into a subscribe call. This updates the handler to perform moves
> instead.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4 
>   src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
> 
> 
> Diff: https://reviews.apache.org/r/66860/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Review Request 66860: Avoid copying of register framework messages in the master.

2018-04-30 Thread Meng Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66860/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-8628
https://issues.apache.org/jira/browse/MESOS-8628


Repository: mesos


Description
---

Prior to this patch, the register framework message was copied
into a subscribe call. This updates the handler to perform moves
instead.


Diffs
-

  src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4 
  src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 


Diff: https://reviews.apache.org/r/66860/diff/1/


Testing
---

make check


Thanks,

Meng Zhu