Re: Review Request 66919: Failure to update registry should abort the master process.

> On May 8, 2018, 12:08 a.m., Jiang Yan Xu wrote: > > src/master/http.cpp > > Lines 4163 (patched) > > > > > > You missed a space between `result)` and `{` which I didn't catch > > initially but fixed up in a

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/#review202606 --- Fix it, then Ship it! FYI committed with some fixes on the

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/#review202578 --- PASS: Mesos patch 66919 was successfully built and tested.

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/ --- (Updated May 7, 2018, 6:10 p.m.) Review request for mesos, Joseph Wu and Jiang

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/ --- (Updated May 7, 2018, 5:20 p.m.) Review request for mesos, Joseph Wu and Jiang

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/ --- (Updated May 7, 2018, 4:54 p.m.) Review request for mesos, Joseph Wu and Jiang

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/#review202496 --- The "process aborting" logic is a bit hard to write tests for but

Re: Review Request 66919: Failure to update registry should abort the master process.

> On May 4, 2018, 8:19 a.m., Jiang Yan Xu wrote: > > src/master/http.cpp > > Lines 4163-4165 (patched) > > > > > > The following will be more idiomatic. > > > > ``` > > .onAny([](const Future&

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/#review202416 --- LGTM It's hard to write a test for this but we can probably

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/#review202327 --- PASS: Mesos patch 66919 was successfully built and tested.

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/#review202322 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/ --- (Updated May 2, 2018, 9:38 p.m.) Review request for mesos. Bugs: MESOS-8630

Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/ --- Review request for mesos. Bugs: MESOS-8630