Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

2018-05-07 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66924/#review202601
---



Patch looks great!

Reviews applied: [66924]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 7, 2018, 11:54 a.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66924/
> ---
> 
> (Updated May 7, 2018, 11:54 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Greg Mann.
> 
> 
> Bugs: MESOS-8784
> https://issues.apache.org/jira/browse/MESOS-8784
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made the master include the operation ID in OPERATION_DROPPED updates.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 76e7763a99972f686af9d7eed08b6b6b1db23b0f 
>   src/master/master.cpp 3b5d2eba3f602f68a6bb1e00444b01fb58a1bfc2 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 71e22af7ac3b7bc4c72340274961db16d7355e7d 
>   src/tests/mesos.hpp 8da3b021874097c5b66e5bc7d9fdafcc8fc377ef 
> 
> 
> Diff: https://reviews.apache.org/r/66924/diff/3/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux.
> 
> 
> The test in this patch fails without the corresponding master change, but 
> succeeds with it applied.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

2018-05-07 Thread Gaston Kleiman 


> On May 7, 2018, 9:41 a.m., Greg Mann wrote:
> > src/tests/master_slave_reconciliation_tests.cpp
> > Lines 496 (patched)
> > 
> >
> > Nit: indented too far.

I ended up removing this callback, as it makes the test flaky and isn't really 
useful.


> On May 7, 2018, 9:41 a.m., Greg Mann wrote:
> > src/tests/mesos.hpp
> > Lines 469 (patched)
> > 
> >
> > Is this necessary?

Yes, it is necessary in order to use `v1::UUID` in the test instead of 
`mesos::v1::UUID`.


- Gaston


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66924/#review202555
---


On May 7, 2018, 11:54 a.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66924/
> ---
> 
> (Updated May 7, 2018, 11:54 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Greg Mann.
> 
> 
> Bugs: MESOS-8784
> https://issues.apache.org/jira/browse/MESOS-8784
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made the master include the operation ID in OPERATION_DROPPED updates.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 76e7763a99972f686af9d7eed08b6b6b1db23b0f 
>   src/master/master.cpp 3b5d2eba3f602f68a6bb1e00444b01fb58a1bfc2 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 71e22af7ac3b7bc4c72340274961db16d7355e7d 
>   src/tests/mesos.hpp 8da3b021874097c5b66e5bc7d9fdafcc8fc377ef 
> 
> 
> Diff: https://reviews.apache.org/r/66924/diff/3/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux.
> 
> 
> The test in this patch fails without the corresponding master change, but 
> succeeds with it applied.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

2018-05-07 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66924/
---

(Updated May 7, 2018, 11:54 a.m.)


Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Greg Mann.


Changes
---

Addressed feedback.


Bugs: MESOS-8784
https://issues.apache.org/jira/browse/MESOS-8784


Repository: mesos


Description
---

Made the master include the operation ID in OPERATION_DROPPED updates.


Diffs (updated)
-

  src/master/master.hpp 76e7763a99972f686af9d7eed08b6b6b1db23b0f 
  src/master/master.cpp 3b5d2eba3f602f68a6bb1e00444b01fb58a1bfc2 
  src/tests/master_slave_reconciliation_tests.cpp 
71e22af7ac3b7bc4c72340274961db16d7355e7d 
  src/tests/mesos.hpp 8da3b021874097c5b66e5bc7d9fdafcc8fc377ef 


Diff: https://reviews.apache.org/r/66924/diff/3/

Changes: https://reviews.apache.org/r/66924/diff/2-3/


Testing
---

`make check` on GNU/Linux.


The test in this patch fails without the corresponding master change, but 
succeeds with it applied.


Thanks,

Gaston Kleiman

Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

2018-05-07 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66924/#review202555
---


Fix it, then Ship it!





src/tests/master_slave_reconciliation_tests.cpp
Lines 496 (patched)


Nit: indented too far.



src/tests/master_slave_reconciliation_tests.cpp
Lines 502 (patched)


Is `WillOnce` sufficient here?



src/tests/master_slave_reconciliation_tests.cpp
Lines 592 (patched)


Is this necessary?



src/tests/mesos.hpp
Lines 469 (patched)


Is this necessary?


- Greg Mann


On May 4, 2018, 11:37 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66924/
> ---
> 
> (Updated May 4, 2018, 11:37 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Greg Mann.
> 
> 
> Bugs: MESOS-8784
> https://issues.apache.org/jira/browse/MESOS-8784
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made the master include the operation ID in OPERATION_DROPPED updates.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 76e7763a99972f686af9d7eed08b6b6b1db23b0f 
>   src/master/master.cpp 3b5d2eba3f602f68a6bb1e00444b01fb58a1bfc2 
>   src/tests/master_slave_reconciliation_tests.cpp 
> 71e22af7ac3b7bc4c72340274961db16d7355e7d 
>   src/tests/mesos.hpp 8da3b021874097c5b66e5bc7d9fdafcc8fc377ef 
> 
> 
> Diff: https://reviews.apache.org/r/66924/diff/2/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux.
> 
> 
> The test in this patch fails without the corresponding master change, but 
> succeeds with it applied.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

2018-05-04 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66924/#review202515
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66924']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66924

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66924/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (112 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1078 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (31 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (72 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (694 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (717 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (718 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (742 ms total)

[--] Global test environment tear-down
[==] 979 tests from 95 test cases ran. (462086 ms total)
[  PASSED  ] 978 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] SlaveTest.RestartSlaveRequireExecutorAuthentication

 1 FAILED TEST
  YOU HAVE 219 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66924/logs/mesos-tests-stderr.log):

```
I0505 02:57:27.794875 17052 slave.cpp:3935] Shutting down framework 
969dced1-813a-48ea-be45-24a8a2cbb9b2-
I0505 02:57:27.794875  5632 master.cpp:10831] Updating the state of task 
7a1fa960-8267-418b-8978-39ac35d37287 of framework 
969dced1-813a-48ea-be45-24a8a2cbb9b2- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0505 02:57:27.794875 17052 slave.cpp:6656] ShuttI0505 02:57:27.633867 15408 
exec.cpp:162] Version: 1.6.0
I0505 02:57:27.659853  2712 exec.cpp:236] Executor registered on agent 
969dced1-813a-48ea-be45-24a8a2cbb9b2-S0
I0505 02:57:27.663861 15328 executor.cpp:178] Received SUBSCRIBED event
I0505 02:57:27.667856 15328 executor.cpp:182] Subscribed executor on 
winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0505 02:57:27.668855 15328 executor.cpp:178] Received LAUNCH event
I0505 02:57:27.672873 15328 executor.cpp:665] Starting task 
7a1fa960-8267-418b-8978-39ac35d37287
I0505 02:57:27.752871 15328 executor.cpp:485] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0505 02:57:27.764875 15328 executor.cpp:678] Forked command at 10752
I0505 02:57:27.796874 16336 exec.cpp:445] Executor asked to shutdown
I0505 02:57:27.797874 12124 executor.cpp:178] Received SHUTDOWN event
I0505 02:57:27.797874 12124 executor.cpp:781] Shutting down
I0505 02:57:27.797874 12124 executor.cpp:894] Sending SIGTERM to process tree 
at pid ing down executor '7a1fa960-8267-418b-8978-39ac35d37287' of framework 
969dced1-813a-48ea-be45-24a8a2cbb9b2- at executor(1)@10.3.1.8:58856
I0505 02:57:27.796874 17052 slave.cpp:929] Agent terminating
W0505 02:57:27.796874 17052 slave.cpp:3931] Ignoring shutdown framework 
969dced1-813a-48ea-be45-24a8a2cbb9b2- because it is terminating
I0505 02:57:27.797874  5632 master.cpp:10930] Removing task 
7a1fa960-8267-418b-8978-39ac35d37287 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 969dced1-813a-48ea-be45-24a8a2cbb9b2- on 
agent 969dced1-813a-48ea-be45-24a8a2cbb9b2-S0 at slave(444)@10.3.1.8:58835 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0505 02:57:27.800869  5632 master.cpp:1293] Agent 
969dced1-813a-48ea-be45-24a8a2cbb9b2-S0 at slave(444)@10.3.1.8:58835 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0505 02:57:27.800869  5632 master.cpp:3299] Disconnecting agent 
969dced1-813a-48ea-be45-24a8a2cbb9b2-S0 at slave(444)@10.3.1.8:58835 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0505 02:57:27.801872 14452 hierarchical.cpp:344] Removed framework 
969dced1-813a-48ea-be45-24a8a2cbb9b2-
I0505 02:57:27.801872  5632 master.cpp:3318] Deactivating agent 
969dced1-813a-48ea-be45-24a8a2cbb9b2-S0 at slave(444)@10.3.1.8:58835

Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

2018-05-04 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66924/
---

(Updated May 4, 2018, 4:37 p.m.)


Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Greg Mann.


Changes
---

Addressed feedback.


Bugs: MESOS-8784
https://issues.apache.org/jira/browse/MESOS-8784


Repository: mesos


Description
---

Made the master include the operation ID in OPERATION_DROPPED updates.


Diffs (updated)
-

  src/master/master.hpp 76e7763a99972f686af9d7eed08b6b6b1db23b0f 
  src/master/master.cpp 3b5d2eba3f602f68a6bb1e00444b01fb58a1bfc2 
  src/tests/master_slave_reconciliation_tests.cpp 
71e22af7ac3b7bc4c72340274961db16d7355e7d 
  src/tests/mesos.hpp 8da3b021874097c5b66e5bc7d9fdafcc8fc377ef 


Diff: https://reviews.apache.org/r/66924/diff/2/

Changes: https://reviews.apache.org/r/66924/diff/1-2/


Testing
---

`make check` on GNU/Linux.


The test in this patch fails without the corresponding master change, but 
succeeds with it applied.


Thanks,

Gaston Kleiman

Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

2018-05-04 Thread Gaston Kleiman 


> On May 4, 2018, 5:39 a.m., Benjamin Bannier wrote:
> > src/master/master.hpp
> > Line 442 (original), 442 (patched)
> > 
> >
> > The original pattern here seems to have been to always consitently 
> > break after the opening paren.
> > 
> > Let's not change that.

We seem to only break after the opening paren if the first parameter is a 
`const process::UPID&`, see these cases in which we don't insert a line break:

https://github.com/apache/mesos/blob/351bade6c28682daf821e88a40140e1364d69cb0/src/master/master.hpp#L523
https://github.com/apache/mesos/blob/351bade6c28682daf821e88a40140e1364d69cb0/src/master/master.hpp#L546
https://github.com/apache/mesos/blob/351bade6c28682daf821e88a40140e1364d69cb0/src/master/master.hpp#L569
https://github.com/apache/mesos/blob/351bade6c28682daf821e88a40140e1364d69cb0/src/master/master.hpp#L573


> On May 4, 2018, 5:39 a.m., Benjamin Bannier wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 3500 (patched)
> > 
> >
> > The behavior described in the comment above seems rather simple, but we 
> > use a pretty complicated setup below. This not only leads to us writing too 
> > much code unrelated to the thing under test, but also introduces unneeded 
> > dependencies on behavior we don't care about (here) -- e.g., I don't think 
> > this test depends on a SLRP. I would also much prefer a non-`ROOT` test so 
> > we run this as often as possible (I suspect developers do not regularly run 
> > `make check` as root on their development machines).
> > 
> > I would suggest to reimplement the test with a `MockResourceProvider` 
> > if we do really need a `CREATE_VOLUME` operation below -- but it seems we 
> > should be able to perform this test with even non-RP operations which would 
> > simplify things further.
> > 
> > See e.g., the test added in r/66908 which needs 60% less test code.

I had originally implemented  test like yours in r/66908, but then remembered 
that Mesos 1.6.0 will not support operation feedback on non-RP resources; I am 
going to add a validation rejecting operations that don't affect RP resources 
but have an operation ID, so we need a test that uses a resource provider.

I agree that there is too much boiler plate in the test, I also think we should 
make it easier to write tests using a SLRP.

We currently have no test that checks that the master correctly forwards the 
`OPERATION_DROPPED` updates generated by a SLRP when an operation ID is 
specified. This test checks that, but if I reimplement it to use a 
`MockResourceProvider`, then we should check in 
`StorageLocalResourceProviderTest.ROOT_ReconcileDroppedOperation` whether the 
update is correctly forwarded to the scheduler.


- Gaston


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66924/#review202436
---


On May 3, 2018, 5 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66924/
> ---
> 
> (Updated May 3, 2018, 5 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Greg Mann.
> 
> 
> Bugs: MESOS-8784
> https://issues.apache.org/jira/browse/MESOS-8784
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made the master include the operation ID in OPERATION_DROPPED updates.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4 
>   src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
>   src/tests/storage_local_resource_provider_tests.cpp 
> ccb114aacc904998dfeef4128f6d38dfb3c865c7 
> 
> 
> Diff: https://reviews.apache.org/r/66924/diff/1/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux.
> 
> 
> The test in this patch fails without the corresponding master change, but 
> succeeds with it applied.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

2018-05-04 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66924/#review202436
---




src/master/master.hpp
Line 442 (original), 442 (patched)


The original pattern here seems to have been to always consitently break 
after the opening paren.

Let's not change that.



src/master/master.hpp
Line 506 (original), 505 (patched)


See above.



src/master/master.hpp
Line 513 (original), 511 (patched)


Break after `(`.



src/tests/storage_local_resource_provider_tests.cpp
Lines 3500 (patched)


The behavior described in the comment above seems rather simple, but we use 
a pretty complicated setup below. This not only leads to us writing too much 
code unrelated to the thing under test, but also introduces unneeded 
dependencies on behavior we don't care about (here) -- e.g., I don't think this 
test depends on a SLRP. I would also much prefer a non-`ROOT` test so we run 
this as often as possible (I suspect developers do not regularly run `make 
check` as root on their development machines).

I would suggest to reimplement the test with a `MockResourceProvider` if we 
do really need a `CREATE_VOLUME` operation below -- but it seems we should be 
able to perform this test with even non-RP operations which would simplify 
things further.

See e.g., the test added in r/66908 which needs 60% less test code.


- Benjamin Bannier


On May 4, 2018, 2 a.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66924/
> ---
> 
> (Updated May 4, 2018, 2 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Greg Mann.
> 
> 
> Bugs: MESOS-8784
> https://issues.apache.org/jira/browse/MESOS-8784
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made the master include the operation ID in OPERATION_DROPPED updates.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4 
>   src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
>   src/tests/storage_local_resource_provider_tests.cpp 
> ccb114aacc904998dfeef4128f6d38dfb3c865c7 
> 
> 
> Diff: https://reviews.apache.org/r/66924/diff/1/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux.
> 
> 
> The test in this patch fails without the corresponding master change, but 
> succeeds with it applied.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

2018-05-04 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66924/#review202418
---



Patch looks great!

Reviews applied: [66908, 66924]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 3, 2018, 5 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66924/
> ---
> 
> (Updated May 3, 2018, 5 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Greg Mann.
> 
> 
> Bugs: MESOS-8784
> https://issues.apache.org/jira/browse/MESOS-8784
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made the master include the operation ID in OPERATION_DROPPED updates.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4 
>   src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
>   src/tests/storage_local_resource_provider_tests.cpp 
> ccb114aacc904998dfeef4128f6d38dfb3c865c7 
> 
> 
> Diff: https://reviews.apache.org/r/66924/diff/1/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux.
> 
> 
> The test in this patch fails without the corresponding master change, but 
> succeeds with it applied.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

2018-05-03 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66924/#review202415
---



PASS: Mesos patch 66924 was successfully built and tested.

Reviews applied: `['66908', '66924']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66924

- Mesos Reviewbot Windows


On May 4, 2018, midnight, Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66924/
> ---
> 
> (Updated May 4, 2018, midnight)
> 
> 
> Review request for mesos, Benjamin Bannier and Greg Mann.
> 
> 
> Bugs: MESOS-8784
> https://issues.apache.org/jira/browse/MESOS-8784
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made the master include the operation ID in OPERATION_DROPPED updates.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4 
>   src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
>   src/tests/storage_local_resource_provider_tests.cpp 
> ccb114aacc904998dfeef4128f6d38dfb3c865c7 
> 
> 
> Diff: https://reviews.apache.org/r/66924/diff/1/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux.
> 
> 
> The test in this patch fails without the corresponding master change, but 
> succeeds with it applied.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Review Request 66924: Made the master include the operation ID in OPERATION_DROPPED updates.

2018-05-03 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66924/
---

Review request for mesos, Benjamin Bannier and Greg Mann.


Bugs: MESOS-8784
https://issues.apache.org/jira/browse/MESOS-8784


Repository: mesos


Description
---

Made the master include the operation ID in OPERATION_DROPPED updates.


Diffs
-

  src/master/master.hpp c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4 
  src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
  src/tests/storage_local_resource_provider_tests.cpp 
ccb114aacc904998dfeef4128f6d38dfb3c865c7 


Diff: https://reviews.apache.org/r/66924/diff/1/


Testing
---

`make check` on GNU/Linux.


The test in this patch fails without the corresponding master change, but 
succeeds with it applied.


Thanks,

Gaston Kleiman