Re: Review Request 67024: Renamed `GRPC_UNSECURE` to `GRPC_VARIANT` in CMake.

2018-05-09 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67024/
---

(Updated May 9, 2018, 7:04 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.


Changes
---

Addressed Benjamin's comment.


Repository: mesos


Description
---

Renamed `GRPC_UNSECURE` to `GRPC_VARIANT` in CMake.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 0075c133ef60bfef06f4123c14cae8a5672440f5 


Diff: https://reviews.apache.org/r/67024/diff/2/

Changes: https://reviews.apache.org/r/67024/diff/1-2/


Testing
---

sudo ninja check


Thanks,

Chun-Hung Hsiao

Re: Review Request 67024: Renamed `GRPC_UNSECURE` to `GRPC_VARIANT` in CMake.

2018-05-09 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67024/#review202785
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On May 8, 2018, 7:27 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67024/
> ---
> 
> (Updated May 8, 2018, 7:27 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed `GRPC_UNSECURE` to `GRPC_VARIANT` in CMake.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 0075c133ef60bfef06f4123c14cae8a5672440f5 
> 
> 
> Diff: https://reviews.apache.org/r/67024/diff/1/
> 
> 
> Testing
> ---
> 
> sudo ninja check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 67024: Renamed `GRPC_UNSECURE` to `GRPC_VARIANT` in CMake.

2018-05-09 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67024/#review202741
---


Fix it, then Ship it!




Ship It!


3rdparty/CMakeLists.txt
Line 1026 (original), 1026 (patched)


Not new, but could you also set this variable on the other branch?

set(GRPC_VARIANT "")


- Benjamin Bannier


On May 9, 2018, 4:27 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67024/
> ---
> 
> (Updated May 9, 2018, 4:27 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed `GRPC_UNSECURE` to `GRPC_VARIANT` in CMake.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 0075c133ef60bfef06f4123c14cae8a5672440f5 
> 
> 
> Diff: https://reviews.apache.org/r/67024/diff/1/
> 
> 
> Testing
> ---
> 
> sudo ninja check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Review Request 67024: Renamed `GRPC_UNSECURE` to `GRPC_VARIANT` in CMake.

2018-05-08 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67024/
---

Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.


Repository: mesos


Description
---

Renamed `GRPC_UNSECURE` to `GRPC_VARIANT` in CMake.


Diffs
-

  3rdparty/CMakeLists.txt 0075c133ef60bfef06f4123c14cae8a5672440f5 


Diff: https://reviews.apache.org/r/67024/diff/1/


Testing
---

sudo ninja check


Thanks,

Chun-Hung Hsiao