Re: Review Request 67243: Windows: Changed test image to custom nanoserver.

2018-05-22 Thread Andrew Schwartzmeyer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67243/#review203614
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On May 21, 2018, 6:39 p.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67243/
> ---
> 
> (Updated May 21, 2018, 6:39 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8499
> https://issues.apache.org/jira/browse/MESOS-8499
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test docker images was based off of the official nanoserver
> powershell image that hasn't been updated for 1803 yet. Since we don't
> actually need powershell for the docker tests, the image has been
> changed to a custom one based off the official nanoserver image, which
> is updated for 1803.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_common.hpp 
> 172eea31ac6006b4b624fb04a64ed4345bd9268d 
>   src/tests/containerizer/docker_tests.cpp 
> e4660f7a931792f33db7978870d215d2d16fa65d 
>   src/tests/health_check_tests.cpp c4661b4f005c18a7cdc69ce05576bcccb79d5dee 
> 
> 
> Diff: https://reviews.apache.org/r/67243/diff/2/
> 
> 
> Testing
> ---
> 
> This was tested in Windows Server 1709 & 1803. Also, tested on Linux.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>



Re: Review Request 67243: Windows: Changed test image to custom nanoserver.

2018-05-22 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67243/#review203597
---



Patch looks great!

Reviews applied: [67207, 67208, 67243]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 22, 2018, 1:39 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67243/
> ---
> 
> (Updated May 22, 2018, 1:39 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8499
> https://issues.apache.org/jira/browse/MESOS-8499
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test docker images was based off of the official nanoserver
> powershell image that hasn't been updated for 1803 yet. Since we don't
> actually need powershell for the docker tests, the image has been
> changed to a custom one based off the official nanoserver image, which
> is updated for 1803.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_common.hpp 
> 172eea31ac6006b4b624fb04a64ed4345bd9268d 
>   src/tests/containerizer/docker_tests.cpp 
> e4660f7a931792f33db7978870d215d2d16fa65d 
>   src/tests/health_check_tests.cpp c4661b4f005c18a7cdc69ce05576bcccb79d5dee 
> 
> 
> Diff: https://reviews.apache.org/r/67243/diff/2/
> 
> 
> Testing
> ---
> 
> This was tested in Windows Server 1709 & 1803. Also, tested on Linux.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>



Re: Review Request 67243: Windows: Changed test image to custom nanoserver.

2018-05-21 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67243/#review203551
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67207', '67208', '67243']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67243

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67243/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (112 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1034 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (34 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (74 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (752 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (776 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (725 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (750 ms total)

[--] Global test environment tear-down
[==] 981 tests from 95 test cases ran. (449793 ms total)
[  PASSED  ] 980 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] 
DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange

 1 FAILED TEST
  YOU HAVE 220 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67243/logs/mesos-tests-stderr.log):

```
I0522 02:14:39.096686 17932 master.cpp:10843] Updating the state of task 
f4b65691-2c1d-42d4-a3df-a990bb66d0a7 of framework 
5545ea6e-0878-46b7-8f30-ce8b5036ed3a- (latest state: TASK_KILLED, status 
updateI0522 02:14:38.937717 11956 exec.cpp:162] Version: 1.7.0
I0522 02:14:38.962725 14832 exec.cpp:236] Executor registered on agent 
5545ea6e-0878-46b7-8f30-ce8b5036ed3a-S0
I0522 02:14:38.966693 16596 executor.cpp:178] Received SUBSCRIBED event
I0522 02:14:38.970675 16596 executor.cpp:182] Subscribed executor on 
windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0522 02:14:38.971675 16596 executor.cpp:178] Received LAUNCH event
I0522 02:14:38.975675 16596 executor.cpp:665] Starting task 
f4b65691-2c1d-42d4-a3df-a990bb66d0a7
I0522 02:14:39.053674 16596 executor.cpp:485] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0522 02:14:39.071677 16596 executor.cpp:678] Forked command at 15352
I0522 02:14:39.099684  2532 exec.cpp:445] Executor asked to shutdown
I0522 02:14:39.099684 18104 executor.cpp:178] Received SHUTDOWN event
I0522 02:14:39.099684 18104 executor.cpp:781] Shutting down
I0522 02:14:39.099684 18104 executor.cpp:894] Sending SIGTERM to process tree 
at pid 15 state: TASK_KILLED)
I0522 02:14:39.096686  8016 slave.cpp:3935] Shutting down framework 
5545ea6e-0878-46b7-8f30-ce8b5036ed3a-
I0522 02:14:39.097692  8016 slave.cpp:6656] Shutting down executor 
'f4b65691-2c1d-42d4-a3df-a990bb66d0a7' of framework 
5545ea6e-0878-46b7-8f30-ce8b5036ed3a- at executor(1)@192.10.1.6:62930
I0522 02:14:39.098685  8016 slave.cpp:929] Agent terminating
W0522 02:14:39.099684  8016 slave.cpp:3931] Ignoring shutdown framework 
5545ea6e-0878-46b7-8f30-ce8b5036ed3a- because it is terminating
I0522 02:14:39.099684 17932 master.cpp:10942] Removing task 
f4b65691-2c1d-42d4-a3df-a990bb66d0a7 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 5545ea6e-0878-46b7-8f30-ce8b5036ed3a- on 
agent 5545ea6e-0878-46b7-8f30-ce8b5036ed3a-S0 at slave(448)@192.10.1.6:62909 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0522 02:14:39.103761 17932 master.cpp:1293] Agent 
5545ea6e-0878-46b7-8f30-ce8b5036ed3a-S0 at slave(448)@192.10.1.6:62909 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0522 02:14:39.103761  7552 hierarchical.cpp:344] Removed framework 
5545ea6e-0878-46b7-8f30-ce8b5036ed3a-
I0522 02:14:39.103761 17932 master.cpp:3303] Disconnecting agent 
5545ea6e-0878-46b7-8f30-ce8b5036ed3a-S0 at slave(448)@192.10.1.6:62909 
(windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0522 02:14:39.103761 17932 master.cpp:3322] Deactivating agent 

Re: Review Request 67243: Windows: Changed test image to custom nanoserver.

2018-05-21 Thread Akash Gupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67243/
---

(Updated May 22, 2018, 1:39 a.m.)


Review request for mesos and Andrew Schwartzmeyer.


Changes
---

Updated outdated comment.


Bugs: MESOS-8499
https://issues.apache.org/jira/browse/MESOS-8499


Repository: mesos


Description
---

The test docker images was based off of the official nanoserver
powershell image that hasn't been updated for 1803 yet. Since we don't
actually need powershell for the docker tests, the image has been
changed to a custom one based off the official nanoserver image, which
is updated for 1803.


Diffs (updated)
-

  src/tests/containerizer/docker_common.hpp 
172eea31ac6006b4b624fb04a64ed4345bd9268d 
  src/tests/containerizer/docker_tests.cpp 
e4660f7a931792f33db7978870d215d2d16fa65d 
  src/tests/health_check_tests.cpp c4661b4f005c18a7cdc69ce05576bcccb79d5dee 


Diff: https://reviews.apache.org/r/67243/diff/2/

Changes: https://reviews.apache.org/r/67243/diff/1-2/


Testing
---

This was tested in Windows Server 1709 & 1803. Also, tested on Linux.


Thanks,

Akash Gupta



Review Request 67243: Windows: Changed test image to custom nanoserver.

2018-05-21 Thread Akash Gupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67243/
---

Review request for mesos and Andrew Schwartzmeyer.


Bugs: MESOS-8499
https://issues.apache.org/jira/browse/MESOS-8499


Repository: mesos


Description
---

The test docker images was based off of the official nanoserver
powershell image that hasn't been updated for 1803 yet. Since we don't
actually need powershell for the docker tests, the image has been
changed to a custom one based off the official nanoserver image, which
is updated for 1803.


Diffs
-

  src/tests/containerizer/docker_common.hpp 
172eea31ac6006b4b624fb04a64ed4345bd9268d 
  src/tests/containerizer/docker_tests.cpp 
e4660f7a931792f33db7978870d215d2d16fa65d 
  src/tests/health_check_tests.cpp c4661b4f005c18a7cdc69ce05576bcccb79d5dee 


Diff: https://reviews.apache.org/r/67243/diff/1/


Testing
---


Thanks,

Akash Gupta