Re: Review Request 67357: Added constant time comparison of JWT signatures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67357/#review204398 --- PASS: Mesos patch 67357 was successfully built and tested. Review

Re: Review Request 67357: Added constant time comparison of JWT signatures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67357/ --- (Updated June 6, 2018, 3:34 p.m.) Review request for mesos and Alexander Ruklet

Re: Review Request 67357: Added constant time comparison of JWT signatures.

> On June 6, 2018, 11:58 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/jwt.cpp > > Lines 213 (patched) > > > > > > To avoid conversions and integral promotions, does it make sense to say > > here > >

Re: Review Request 67357: Added constant time comparison of JWT signatures.

> On June 6, 2018, 12:26 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['67357']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > > http://dcos-win.westus.c

Re: Review Request 67357: Added constant time comparison of JWT signatures.

> On May 31, 2018, 4:56 p.m., Benno Evers wrote: > > 3rdparty/libprocess/src/jwt.cpp > > Lines 205 (patched) > > > > > > To be more precise: "which compares either none of the content or the > > whole content of the

Re: Review Request 67357: Added constant time comparison of JWT signatures.

> On June 6, 2018, 11:58 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/jwt.cpp > > Lines 213 (patched) > > > > > > To avoid conversions and integral promotions, does it make sense to say > > here > >

Re: Review Request 67357: Added constant time comparison of JWT signatures.

> On June 6, 2018, 10:26 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['67357']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > > http://dcos-win.westus.c

Re: Review Request 67357: Added constant time comparison of JWT signatures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67357/#review204374 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67357: Added constant time comparison of JWT signatures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67357/ --- (Updated June 6, 2018, 10:31 a.m.) Review request for mesos and Alexander Rukle

Re: Review Request 67357: Added constant time comparison of JWT signatures.

> On May 31, 2018, 6:56 p.m., Benno Evers wrote: > > 3rdparty/libprocess/src/jwt.cpp > > Lines 205 (patched) > > > > > > To be more precise: "which compares either none of the content or the > > whole content of the

Re: Review Request 67357: Added constant time comparison of JWT signatures.

> On May 30, 2018, 1:37 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/jwt.cpp > > Line 253 (original), 253-261 (patched) > > > > > > I suggest to exatract it into a funciton, say `compareConstantTime`.

Re: Review Request 67357: Added constant time comparison of JWT signatures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67357/#review204109 --- PASS: Mesos patch 67357 was successfully built and tested. Review

Re: Review Request 67357: Added constant time comparison of JWT signatures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67357/ --- (Updated May 31, 2018, 11:02 a.m.) Review request for Alexander Rukletsov. Re

Re: Review Request 67357: Added constant time comparison of JWT signatures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67357/#review203996 --- PASS: Mesos patch 67357 was successfully built and tested. Review

Review Request 67357: Added constant time comparison of JWT signatures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67357/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos Descripti