Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

2018-10-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67414/#review209290 --- Fix it, then Ship it! Thanks! I'll fix the outstanding issues

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

2018-10-05 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67414/#review209280 --- Bad patch! Reviews applied: [67414] Failed command: python

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

2018-10-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67414/#review209274 --- PASS: Mesos patch 67414 was successfully built and tested.

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

2018-10-05 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67414/ --- (Updated Oct. 5, 2018, 4:45 p.m.) Review request for mesos and Alexander

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

2018-10-05 Thread Alexander Rukletsov
> On June 5, 2018, 10:46 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/include/process/http.hpp > > Line 701 (original), 701-702 (patched) > > > > > > Why not using `process::http::Status::string()` > >

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

2018-06-15 Thread Benno Evers
> On June 5, 2018, 10:46 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/include/process/http.hpp > > Line 701 (original), 701-702 (patched) > > > > > > Why not using `process::http::Status::string()` > >

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

2018-06-14 Thread Alexander Rukletsov
> On June 5, 2018, 10:46 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/include/process/http.hpp > > Line 701 (original), 701-702 (patched) > > > > > > Why not using `process::http::Status::string()` > >

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

2018-06-07 Thread Benno Evers
> On June 5, 2018, 10:46 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/include/process/http.hpp > > Line 701 (original), 701-702 (patched) > > > > > > Why not using `process::http::Status::string()` > >

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

2018-06-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67414/#review204313 --- 3rdparty/libprocess/include/process/http.hpp Line 701

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

2018-06-01 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67414/#review204215 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

2018-06-01 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67414/#review204191 --- PASS: Mesos patch 67414 was successfully built and tested.

Review Request 67414: Added default message bodies to libprocess HTTP error responses.

2018-06-01 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67414/ --- Review request for mesos. Repository: mesos Description --- By default