Re: Review Request 67534: CMake: Added libapr as interface dependency of libsvn.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67534/#review204595
---



Patch looks great!

Reviews applied: [67534]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 11, 2018, 2:57 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67534/
> ---
> 
> (Updated June 11, 2018, 2:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Apache Portable Runtime library is used only because SVN requires
> it, so SVN should explicitly require it in its interface.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
> 
> 
> Diff: https://reviews.apache.org/r/67534/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67534: CMake: Added libapr as interface dependency of libsvn.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67534/#review204594
---




3rdparty/CMakeLists.txt
Lines 652 (patched)


This change looks invalid to me as one can dynamically link against any 
`libsvn-*` just fine without also requiring apr.

This change pushes a dependency we have in stout due to the way we interact 
with the `svn` libraries into an external project. That looks unnecessarily 
messy to me. We could instead make sure `apr` is only a dependency when `svn` 
is a dependency.

Also see my comment https://reviews.apache.org/r/67535/#comment287173.


- Benjamin Bannier


On June 11, 2018, 11:57 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67534/
> ---
> 
> (Updated June 11, 2018, 11:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Apache Portable Runtime library is used only because SVN requires
> it, so SVN should explicitly require it in its interface.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
> 
> 
> Diff: https://reviews.apache.org/r/67534/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67534: CMake: Added libapr as interface dependency of libsvn.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67534/#review204573
---



PASS: Mesos patch 67534 was successfully built and tested.

Reviews applied: `['67534']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67534

- Mesos Reviewbot Windows


On June 11, 2018, 9:57 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67534/
> ---
> 
> (Updated June 11, 2018, 9:57 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Apache Portable Runtime library is used only because SVN requires
> it, so SVN should explicitly require it in its interface.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
> 
> 
> Diff: https://reviews.apache.org/r/67534/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Review Request 67534: CMake: Added libapr as interface dependency of libsvn.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67534/
---

Review request for mesos, Benjamin Bannier and Joseph Wu.


Repository: mesos


Description
---

The Apache Portable Runtime library is used only because SVN requires
it, so SVN should explicitly require it in its interface.


Diffs
-

  3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 


Diff: https://reviews.apache.org/r/67534/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer