Re: Review Request 67547: Added check for API endpoints that do not support streaming responses.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204661
---



Patch looks great!

Reviews applied: [67546, 67547]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 12, 2018, 4:08 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67547/
> ---
> 
> (Updated June 12, 2018, 4:08 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
> 
> 
> Bugs: MESOS-8985
> https://issues.apache.org/jira/browse/MESOS-8985
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A client can request any endpoint to stream its response using
> the RecordIO format. However, we never checked whether the selected
> endpoint actually supports streaming, leading to an agent crash
> when it was used for endpoints that did not expect such a request.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c 
>   src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328 
> 
> 
> Diff: https://reviews.apache.org/r/67547/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67547: Added check for API endpoints that do not support streaming responses.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204616
---



PASS: Mesos patch 67547 was successfully built and tested.

Reviews applied: `['67546', '67547']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67547

- Mesos Reviewbot Windows


On June 12, 2018, 4:08 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67547/
> ---
> 
> (Updated June 12, 2018, 4:08 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
> 
> 
> Bugs: MESOS-8985
> https://issues.apache.org/jira/browse/MESOS-8985
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A client can request any endpoint to stream its response using
> the RecordIO format. However, we never checked whether the selected
> endpoint actually supports streaming, leading to an agent crash
> when it was used for endpoints that did not expect such a request.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c 
>   src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328 
> 
> 
> Diff: https://reviews.apache.org/r/67547/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67547: Added check for API endpoints that do not support streaming responses.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67547/#review204612
---




src/slave/http.cpp
Lines 559 (patched)


remove one single quote


- Alexander Rukletsov


On June 12, 2018, 4:08 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67547/
> ---
> 
> (Updated June 12, 2018, 4:08 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
> 
> 
> Bugs: MESOS-8985
> https://issues.apache.org/jira/browse/MESOS-8985
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A client can request any endpoint to stream its response using
> the RecordIO format. However, we never checked whether the selected
> endpoint actually supports streaming, leading to an agent crash
> when it was used for endpoints that did not expect such a request.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp ba43086f745b0171f699e9ccf90a505f2c5d0f8c 
>   src/tests/api_tests.cpp 84368707e2c0bcf66bbfb308a4b863112119d328 
> 
> 
> Diff: https://reviews.apache.org/r/67547/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>