Re: Review Request 67551: Fixed `push-commits.py` for Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67551/#review204666 --- Ship it! Ship It! - Armand Grillet On June 12, 2018, 5:41 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67551/ > --- > > (Updated June 12, 2018, 5:41 p.m.) > > > Review request for mesos and Armand Grillet. > > > Repository: mesos > > > Description > --- > > This script didn't work even before the port to Python 3, as > `os.path.join` cannot be used for joining URL components, as the > filesystem path separator on Windows is a backslash. > > > Diffs > - > > support/python3/push-commits.py ef63d1a7c05605cebcce9cdcb6d38365570a1b59 > > > Diff: https://reviews.apache.org/r/67551/diff/1/ > > > Testing > --- > > > python .\support\python3\push-commits.py --dry-run > Pushing commits to apache > To https://git-wip-us.apache.org/repos/asf/mesos.git >f1c0377a9..8ffe29363 master -> master > Closing review 67551 > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 67551: Fixed `push-commits.py` for Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67551/#review204664 --- Patch looks great! Reviews applied: [67551] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 13, 2018, 1:41 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67551/ > --- > > (Updated June 13, 2018, 1:41 a.m.) > > > Review request for mesos and Armand Grillet. > > > Repository: mesos > > > Description > --- > > This script didn't work even before the port to Python 3, as > `os.path.join` cannot be used for joining URL components, as the > filesystem path separator on Windows is a backslash. > > > Diffs > - > > support/python3/push-commits.py ef63d1a7c05605cebcce9cdcb6d38365570a1b59 > > > Diff: https://reviews.apache.org/r/67551/diff/1/ > > > Testing > --- > > > python .\support\python3\push-commits.py --dry-run > Pushing commits to apache > To https://git-wip-us.apache.org/repos/asf/mesos.git >f1c0377a9..8ffe29363 master -> master > Closing review 67551 > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 67551: Fixed `push-commits.py` for Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67551/#review204634 --- PASS: Mesos patch 67551 was successfully built and tested. Reviews applied: `['67551']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67551 - Mesos Reviewbot Windows On June 12, 2018, 10:41 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67551/ > --- > > (Updated June 12, 2018, 10:41 a.m.) > > > Review request for mesos and Armand Grillet. > > > Repository: mesos > > > Description > --- > > This script didn't work even before the port to Python 3, as > `os.path.join` cannot be used for joining URL components, as the > filesystem path separator on Windows is a backslash. > > > Diffs > - > > support/python3/push-commits.py ef63d1a7c05605cebcce9cdcb6d38365570a1b59 > > > Diff: https://reviews.apache.org/r/67551/diff/1/ > > > Testing > --- > > > python .\support\python3\push-commits.py --dry-run > Pushing commits to apache > To https://git-wip-us.apache.org/repos/asf/mesos.git >f1c0377a9..8ffe29363 master -> master > Closing review 67551 > > > Thanks, > > Andrew Schwartzmeyer > >
Review Request 67551: Fixed `push-commits.py` for Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67551/ --- Review request for mesos and Armand Grillet. Repository: mesos Description --- This script didn't work even before the port to Python 3, as `os.path.join` cannot be used for joining URL components, as the filesystem path separator on Windows is a backslash. Diffs - support/python3/push-commits.py ef63d1a7c05605cebcce9cdcb6d38365570a1b59 Diff: https://reviews.apache.org/r/67551/diff/1/ Testing --- > python .\support\python3\push-commits.py --dry-run Pushing commits to apache To https://git-wip-us.apache.org/repos/asf/mesos.git f1c0377a9..8ffe29363 master -> master Closing review 67551 Thanks, Andrew Schwartzmeyer
