Re: Review Request 67554: Removed headers from `libprocess/src/CMakeList.txt`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67554/#review204797 --- Ship it! Ship It! - Benjamin Bannier On June 12, 2018, 11:09 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67554/ > --- > > (Updated June 12, 2018, 11:09 p.m.) > > > Review request for mesos, Akash Gupta, Benjamin Bannier, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Header files are not necessary (and so are redundant) in CMake. > > > Diffs > - > > 3rdparty/libprocess/src/CMakeLists.txt > eb88afb8bef1205d0c14a6a6cf414d99f20eb1a7 > > > Diff: https://reviews.apache.org/r/67554/diff/1/ > > > Testing > --- > > libprocess-tests built and ran on Windows. > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 67554: Removed headers from `libprocess/src/CMakeList.txt`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67554/#review204682 --- Patch looks great! Reviews applied: [67554] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 12, 2018, 9:09 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67554/ > --- > > (Updated June 12, 2018, 9:09 p.m.) > > > Review request for mesos, Akash Gupta, Benjamin Bannier, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Header files are not necessary (and so are redundant) in CMake. > > > Diffs > - > > 3rdparty/libprocess/src/CMakeLists.txt > eb88afb8bef1205d0c14a6a6cf414d99f20eb1a7 > > > Diff: https://reviews.apache.org/r/67554/diff/1/ > > > Testing > --- > > libprocess-tests built and ran on Windows. > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 67554: Removed headers from `libprocess/src/CMakeList.txt`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67554/#review204646 --- PASS: Mesos patch 67554 was successfully built and tested. Reviews applied: `['67554']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67554 - Mesos Reviewbot Windows On June 12, 2018, 9:09 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67554/ > --- > > (Updated June 12, 2018, 9:09 p.m.) > > > Review request for mesos, Akash Gupta, Benjamin Bannier, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Header files are not necessary (and so are redundant) in CMake. > > > Diffs > - > > 3rdparty/libprocess/src/CMakeLists.txt > eb88afb8bef1205d0c14a6a6cf414d99f20eb1a7 > > > Diff: https://reviews.apache.org/r/67554/diff/1/ > > > Testing > --- > > libprocess-tests built and ran on Windows. > > > Thanks, > > Andrew Schwartzmeyer > >
Review Request 67554: Removed headers from `libprocess/src/CMakeList.txt`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67554/ --- Review request for mesos, Akash Gupta, Benjamin Bannier, and Joseph Wu. Repository: mesos Description --- Header files are not necessary (and so are redundant) in CMake. Diffs - 3rdparty/libprocess/src/CMakeLists.txt eb88afb8bef1205d0c14a6a6cf414d99f20eb1a7 Diff: https://reviews.apache.org/r/67554/diff/1/ Testing --- libprocess-tests built and ran on Windows. Thanks, Andrew Schwartzmeyer
