Re: Review Request 67574: Made `PerfEventSubsystemProcess` can be created without `--perf_events`.

2018-06-18 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67574/#review204979
---


Ship it!




Ship It!

- Gilbert Song


On June 13, 2018, 7:23 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67574/
> ---
> 
> (Updated June 13, 2018, 7:23 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If the agent flag `--perf_events` is not specified, the `perf_event`
> subsystem (i.e., `PerfEventSubsystemProcess`) can still be created, but
> it will not do sampling at all. The reason that we want to do this is,
> in some cases, even it is not required to sample any events, we still
> want each container to have its own `perf_event` cgroup instead under
> the root cgroup.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/perf_event.cpp 
> 06eca0c008ca7ddb45e4d10e63fdc2c601de430b 
> 
> 
> Diff: https://reviews.apache.org/r/67574/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Review Request 67574: Made `PerfEventSubsystemProcess` can be created without `--perf_events`.

2018-06-13 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67574/
---

Review request for mesos and Gilbert Song.


Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description
---

If the agent flag `--perf_events` is not specified, the `perf_event`
subsystem (i.e., `PerfEventSubsystemProcess`) can still be created, but
it will not do sampling at all. The reason that we want to do this is,
in some cases, even it is not required to sample any events, we still
want each container to have its own `perf_event` cgroup instead under
the root cgroup.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/perf_event.cpp 
06eca0c008ca7ddb45e4d10e63fdc2c601de430b 


Diff: https://reviews.apache.org/r/67574/diff/1/


Testing
---


Thanks,

Qian Zhang